Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last round of PR remediations #2791

Merged
merged 10 commits into from
Dec 20, 2023
Merged

last round of PR remediations #2791

merged 10 commits into from
Dec 20, 2023

Conversation

daniel-savu
Copy link
Contributor

Remediations for #2746, in addition to #2780

@daniel-savu daniel-savu requested a review from tkporter as a code owner October 10, 2023 19:36
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2791 (8cd8f25) into main (6044fb8) will decrease coverage by 3.16%.
Report is 79 commits behind head on main.
The diff coverage is n/a.

❗ Current head 8cd8f25 differs from pull request most recent head 84a0b2b. Consider uploading reports for the commit 84a0b2b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2791      +/-   ##
==========================================
- Coverage   67.51%   64.35%   -3.16%     
==========================================
  Files         101       97       -4     
  Lines        1022      968      -54     
  Branches      106      101       -5     
==========================================
- Hits          690      623      -67     
- Misses        292      308      +16     
+ Partials       40       37       -3     
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 67.93% <ø> (-2.99%) ⬇️
isms 68.65% <ø> (-1.85%) ⬇️
token 84.84% <ø> (+30.21%) ⬆️
middlewares 73.17% <ø> (-8.30%) ⬇️

@daniel-savu daniel-savu changed the base branch from v3 to main December 15, 2023 16:59
Copy link

changeset-bot bot commented Dec 15, 2023

⚠️ No Changeset found

Latest commit: 84a0b2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rust/hyperlane-base/src/settings/chains.rs Outdated Show resolved Hide resolved
@daniel-savu daniel-savu enabled auto-merge (squash) December 20, 2023 11:57
auto-merge was automatically disabled December 20, 2023 15:19

Base branch was modified

@daniel-savu daniel-savu enabled auto-merge (squash) December 20, 2023 15:20
@daniel-savu daniel-savu merged commit f73ee0b into main Dec 20, 2023
11 of 17 checks passed
@daniel-savu daniel-savu deleted the v3-agent-remediations branch December 20, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants