Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reduce agents log verbosity, reword #3026

Merged
merged 3 commits into from
Dec 5, 2023
Merged

chore: reduce agents log verbosity, reword #3026

merged 3 commits into from
Dec 5, 2023

Conversation

daniel-savu
Copy link
Contributor

There are way too many No message found in DB for leaf index logs to have them at debug level. Also the wording makes it seem like an error when it's not.

@daniel-savu daniel-savu requested a review from tkporter as a code owner December 5, 2023 12:33
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2797981

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tkporter
tkporter approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change, this log is so annoying

rust/agents/relayer/src/merkle_tree/processor.rs Outdated Show resolved Hide resolved
@daniel-savu daniel-savu enabled auto-merge (squash) December 5, 2023 14:49
@daniel-savu daniel-savu merged commit 36de5bc into main Dec 5, 2023
10 of 16 checks passed
@daniel-savu daniel-savu deleted the dan/reduce-log-verbosity branch December 5, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkporter tkporter tkporter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-savu @tkporter