Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cosmos balance parsing #3036

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

daniel-savu
Copy link
Contributor

@daniel-savu daniel-savu commented Dec 7, 2023

@tkporter reported that cosmos balance strings were being interpreted as hex when parsed, causing them to appear much larger. This fixes by parsing as decimal.

Tested manually by checking the metrics endpoint.

@daniel-savu daniel-savu requested a review from tkporter as a code owner December 7, 2023 14:57
Copy link

changeset-bot bot commented Dec 7, 2023

⚠️ No Changeset found

Latest commit: 2cd538d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@daniel-savu daniel-savu merged commit 86b7f98 into main Dec 7, 2023
10 of 16 checks passed
@daniel-savu daniel-savu deleted the dan/fix-cosmos-balance-parsing branch December 7, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants