Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sealevel v3 contracts #3048

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Sealevel v3 contracts #3048

merged 7 commits into from
Dec 15, 2023

Conversation

daniel-savu
Copy link
Contributor

@daniel-savu daniel-savu commented Dec 11, 2023 •
edited
Loading

Description

MVP contracts for sealevel v3 - note this doesn't include hooks so IGP payments still have to be made separately. However contracts will now be compatible with the metadata format used by the other V3 deployments.

Drive-by changes

The unit tests in rust/sealevel/programs/ism/multisig-ism-message-id/src/metadata.rs are refactored to reuse struct creation logic.

Related issues

Backward compatibility

No, since this upgrades sealevel v2 to v3.

Testing

Unit tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 222268b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@daniel-savu daniel-savu marked this pull request as ready for review December 12, 2023 14:26
@daniel-savu daniel-savu changed the title chore(sealevel): upgrade message version to v3 Sealevel v3 contracts Dec 12, 2023
@daniel-savu daniel-savu mentioned this pull request Dec 13, 2023
Merged
tkporter
tkporter approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why tests are failing tbh, but code changes do lgtm

rust/sealevel/programs/ism/multisig-ism-message-id/src/metadata.rs Outdated Show resolved Hide resolved
@daniel-savu
Copy link
Contributor Author

daniel-savu commented Dec 15, 2023 •
edited
Loading

Unsure why tests are failing tbh, but code changes do lgtm

Issue was that since message version is now 3 instead of 0, I needed to recompute the hardcoded validator signatures when testing the multisig ISM

@daniel-savu daniel-savu enabled auto-merge (squash) December 15, 2023 12:01
@daniel-savu daniel-savu merged commit 42ea929 into main Dec 15, 2023
16 of 17 checks passed
@daniel-savu daniel-savu deleted the dan/sealevel-v3 branch December 15, 2023 12:19
daniel-savu added a commit that referenced this pull request Dec 19, 2023
@daniel-savu
feat: sealevel merkle indexer + e2e (#3053)
8e44bc1 
Depends on #3048

Fixes #3046
Fixes #2754
yorhodes pushed a commit that referenced this pull request Dec 20, 2023
@daniel-savu @yorhodes
feat: sealevel merkle indexer + e2e (#3053)
3e63048 
Depends on #3048

Fixes #3046
Fixes #2754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkporter tkporter tkporter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sealevel V3: change ISM metadata format to match v3 metadata Sealevel V3: change message version to match V3
2 participants
@daniel-savu @tkporter