Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
dry_run_verify
for the aggregation ISM on cosmwasm. One remaining issue is that the estimated gas is hardcoded to1
, because we're actually just querying via rpc rather than simulating a tx. Theverify
tx isn't marked as a contract entrypoint so it can't be called from outside iiuc. (here's the verify fn for reference).Worth mentioning that the query interface for the aggregation ISM is named incorrectly - it should return fields called
threshold
andmodules
, but instead copies the response from the multisig ISM and returnsthreshold
andvalidators
. This can be particularly misleading because validators have 20-bytes long addresses, whereas modules (contracts) have 32-bytes long addresses.Related issues
Backward compatibility
yes
Testing
E2E. The ISM setup is
routing
->aggregation (1/1)
->multisig (1/1)