Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosmos): ism dry-run #3077

Merged
merged 6 commits into from
Dec 20, 2023
Merged

feat(cosmos): ism dry-run #3077

merged 6 commits into from
Dec 20, 2023

Conversation

daniel-savu
Copy link
Contributor

@daniel-savu daniel-savu commented Dec 19, 2023

Description

Implements dry_run_verify for the aggregation ISM on cosmwasm. One remaining issue is that the estimated gas is hardcoded to 1, because we're actually just querying via rpc rather than simulating a tx. The verify tx isn't marked as a contract entrypoint so it can't be called from outside iiuc. (here's the verify fn for reference).

Worth mentioning that the query interface for the aggregation ISM is named incorrectly - it should return fields called threshold and modules, but instead copies the response from the multisig ISM and returns threshold and validators. This can be particularly misleading because validators have 20-bytes long addresses, whereas modules (contracts) have 32-bytes long addresses.

Related issues

Backward compatibility

yes

Testing

E2E. The ISM setup is routing -> aggregation (1/1) -> multisig (1/1)

Copy link

changeset-bot bot commented Dec 19, 2023

⚠️ No Changeset found

Latest commit: 395ac44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@daniel-savu daniel-savu marked this pull request as ready for review December 19, 2023 22:16
@daniel-savu daniel-savu enabled auto-merge (squash) December 20, 2023 14:07
@daniel-savu daniel-savu disabled auto-merge December 20, 2023 14:07
@daniel-savu daniel-savu enabled auto-merge (squash) December 20, 2023 14:22
auto-merge was automatically disabled December 20, 2023 15:19

Base branch was modified

@daniel-savu daniel-savu enabled auto-merge (squash) December 20, 2023 15:46
@daniel-savu daniel-savu merged commit c2cf7be into main Dec 20, 2023
11 of 17 checks passed
@daniel-savu daniel-savu deleted the dan/cosmos-ism-dryrun branch December 20, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants