Hacky solana balance monitoring #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v2 #3432 +/- ##
=======================================
Coverage 67.91% 67.91%
=======================================
Files 95 95
Lines 1446 1446
Branches 189 189
=======================================
Hits 982 982
Misses 457 457
Partials 7 7
|
nambrot
approved these changes
Mar 18, 2024
daniel-savu
pushed a commit
that referenced
this pull request
Jun 5, 2024
### Description - See hyperlane-xyz/issues#1047 - Intentionally going with a "hacky" short term approach because we consistently hit this, we're unlikely to prioritize a better solution for v3, and this change is only for v2 which we are in maintenance-only mode, so it's ok to hardcode these accounts ### Drive-by changes - New monorepo base image to fix building, which requires node 18 apparently ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
### Description - Tested and set up alerts - We already have the relayer balances from the agents themselves, so just need the ATA payers (which are responsible for paying for the rent of token accounts that don't yet exist when bridging in) - Putting it here because it's easy and this is what we did in v2 (see #3432, which this is based off) ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> --------- Co-authored-by: Paul Balaji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Backward compatibility
Testing