Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacky bsc gas price override on v2 #4269

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Aug 7, 2024

Description

Drive-by changes

Related issues

Backward compatibility

Testing

@tkporter tkporter requested a review from daniel-savu as a code owner August 7, 2024 08:42
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: 1733a5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.68%. Comparing base (9093fd0) to head (e89671b).

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #4269      +/-   ##
==========================================
- Coverage   72.70%   72.68%   -0.02%     
==========================================
  Files          95       97       +2     
  Lines        1480     1490      +10     
  Branches      189      191       +2     
==========================================
+ Hits         1076     1083       +7     
- Misses        395      401       +6     
+ Partials        9        6       -3     
Components Coverage Δ
core 91.66% <ø> (-3.17%) ⬇️
hooks 61.53% <ø> (ø)
isms 71.60% <ø> (-0.42%) ⬇️
token ∅ <ø> (∅)
middlewares 63.63% <ø> (-0.16%) ⬇️

@tkporter tkporter enabled auto-merge (squash) August 7, 2024 11:10
@tkporter tkporter disabled auto-merge August 7, 2024 11:10
@tkporter tkporter requested a review from nambrot as a code owner August 7, 2024 11:17
@tkporter tkporter enabled auto-merge (squash) August 7, 2024 11:17
@tkporter tkporter merged commit 5491bca into v2 Aug 7, 2024
13 of 14 checks passed
@tkporter tkporter deleted the trevor/v2-allow-bsc-gas-price branch August 7, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants