Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): set profile overrides in root manifest #4407

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

daniel-savu
Copy link
Contributor

Description

Backport of #4402

Fixes cargo build-sbf warnings by moving all profile overrides to rust/Cargo.toml, so they actually take effect.

@daniel-savu daniel-savu requested a review from tkporter as a code owner August 30, 2024 11:20
Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: 59faa8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤴

@daniel-savu daniel-savu enabled auto-merge (squash) August 30, 2024 11:25
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.02%. Comparing base (0be930d) to head (59faa8b).
Report is 1 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #4407   +/-   ##
=======================================
  Coverage   74.02%   74.02%           
=======================================
  Files          97       97           
  Lines        1490     1490           
  Branches      191      191           
=======================================
  Hits         1103     1103           
  Misses        381      381           
  Partials        6        6           
Components Coverage Δ
core 91.66% <ø> (ø)
hooks 84.61% <ø> (ø)
isms 73.25% <ø> (ø)
token ∅ <ø> (∅)
middlewares 64.06% <ø> (ø)

@daniel-savu daniel-savu merged commit 08a0310 into v2 Aug 30, 2024
22 of 29 checks passed
@daniel-savu daniel-savu deleted the dan/overflow-profile-overrides branch August 30, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants