Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(treasure): gas price estimation #4992

Merged
merged 4 commits into from
Dec 13, 2024
+14 −3
Merged

fix(treasure): gas price estimation #4992

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b40a1b
fix(treasure): gas price estimation
daniel-savu Dec 12, 2024
6cedcf0
bump by even more
daniel-savu Dec 12, 2024
46c5f92
nits
daniel-savu Dec 12, 2024
ca64258
only 2x
daniel-savu Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions rust/main/chains/hyperlane-ethereum/src/tx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use std::sync::Arc;
use std::time::Duration;
use std::{ops::Mul, sync::Arc};

use ethers::{
abi::Detokenize,
Expand Down Expand Up @@ -154,7 +154,7 @@ where
}

let Ok((base_fee, max_fee, max_priority_fee)) =
estimate_eip1559_fees(provider, None, &latest_block).await
estimate_eip1559_fees(provider, None, &latest_block, domain).await
else {
// Is not EIP 1559 chain
return Ok(tx.gas(gas_limit));
Expand Down Expand Up @@ -210,6 +210,7 @@ async fn estimate_eip1559_fees<M>(
provider: Arc<M>,
estimator: Option<FeeEstimator>,
latest_block: &Block<TxHash>,
domain: &HyperlaneDomain,
) -> ChainResult<(EthersU256, EthersU256, EthersU256)>
where
M: Middleware + 'static,
Expand All @@ -234,7 +235,17 @@ where
eip1559_default_estimator(base_fee_per_gas, fee_history.reward)
};

Ok((base_fee_per_gas, max_fee_per_gas, max_priority_fee_per_gas))
let mut gas_price_multiplier: u32 = 1;
// `treasure` chain gas estimation underestimates the actual gas price, so we double it
if domain.id() == 61166 {
daniel-savu marked this conversation as resolved.
Show resolved Hide resolved
gas_price_multiplier = 2;
}

Ok((
base_fee_per_gas.mul(gas_price_multiplier),
max_fee_per_gas.mul(gas_price_multiplier),
max_priority_fee_per_gas.mul(gas_price_multiplier),
))
}

pub(crate) async fn call_with_reorg_period<M, T>(
Expand Down
Loading