Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove GCP storage dependency from SDK #5000

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Dec 13, 2024

Description

  • feat: remove GCP storage dependency
  • call GCP storage API directly

Drive-by changes

  • little refactor
  • add dec 4 batch sha to the validator version checker

Related issues

Backward compatibility

Testing

test by checking version of flowmainnet validators, because we know the flow foundation validator is on GCP storage https://evm.flowscan.io/tx/0x4ac998b0d35b3d305e792ee608818a398d09ee11851e09e37068f67ce8c6153f?tab=logs

# from repo root
yarn --cwd typescript/infra tsx scripts/check/check-validator-version.ts -e mainnet3 -c flowmainnet --show-updated
✅ 4 Validators with expected git SHA:
┌─────────┬───────────────┬──────────────────────────────────────────────┬───────────────────┬───────────────┐
│ (index) │ chain         │ validator                                    │ alias             │ version       │
├─────────┼───────────────┼──────────────────────────────────────────────┼───────────────────┼───────────────┤
│ 0       │ 'flowmainnet' │ '0xe132235c958ca1f3f24d772e5970dd58da4c0f6e' │ 'Abacus Works'    │ 'nov-7-batch' │
│ 1       │ 'flowmainnet' │ '0x14ADB9e3598c395Fe3290f3ba706C3816Aa78F59' │ 'Flow Foundation' │ 'nov-7-batch' │
│ 2       │ 'flowmainnet' │ '0xcf0211fafbb91fd9d06d7e306b30032dc3a1934f' │ 'Merkly'          │ 'nov-7-batch' │
│ 3       │ 'flowmainnet' │ '0x4f977a59fdc2d9e39f6d780a84d5b4add1495a36' │ 'Mitosis'         │ 'dec-4-batch' │
└─────────┴───────────────┴──────────────────────────────────────────────┴───────────────────┴───────────────┘

✅ All validators running expected git SHA!

Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 7ba7051

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paulbalaji paulbalaji requested review from xeno097 and removed request for yorhodes, ltyu and Mo-Hussain December 13, 2024 12:06
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (629b2bc) to head (7ba7051).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5000   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

typescript/sdk/src/gcp/storage.ts Outdated Show resolved Hide resolved
typescript/sdk/src/gcp/storage.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm

typescript/sdk/package.json Show resolved Hide resolved
typescript/sdk/src/gcp/storage.ts Outdated Show resolved Hide resolved
@paulbalaji paulbalaji enabled auto-merge December 13, 2024 19:57
@paulbalaji paulbalaji added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 82cebab Dec 13, 2024
41 checks passed
@paulbalaji paulbalaji deleted the pb/move-gcp-storage branch December 13, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants