test(test-plugin-ledger-connector-besu): jestify get-block-endpoint

[krriscode]

test(test-plugin-ledger-connector-besu): jestify get-block-endpoint

Primary Changes:

packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/get-block-endpoint.test.ts

Fixes: #3500

Signed-off-by: krriscode [email protected]

Migration of get-block-endpoint.ts from tape-promise to Jest. Update tests for improved reliability and performance.

Pull Request Requirements

• Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
• Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
• Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

• Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
• Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

[petermetz]

@krriscode Looking good, thank you!

[petermetz]

@krriscode Please fix the commit lint check by modifying the git commit message. It looks like you need a line break somewhere to make the lines less than 100 characters each.

If you need any help with the git mechanics involved just let me know and I can help.

[krriscode]

Hi @petermetz,
I have fixed the commit message as you suggested
please review the PR.

[petermetz]

@krriscode Getting closer! Now the commit message is looking good but you are not doing the signoff with the correct name and/or email address. Please see the details here:

https://github.com/hyperledger-cacti/cacti/pull/3607/checks?check_run_id=32664817913

[petermetz]

@krriscode Same issue still. There's a more detailed explanation of how it works that might help if you read all of that: https://stackoverflow.com/a/62972983/698470

[petermetz]

@krriscode The sign off is still not working. You are trying to submit your pull request being signed off as someone else:

 Error: The SoB (DCO) check failed

  9f62e82005578755f233384042f0b0068e5fea6a    Expected "Udhayakumari <[email protected]>", but got "krriscode <[email protected]>".

  What should I do to fix it ?

  All proposed commits should include a Signed-off-by: <your-name> <your-email-address> line in their commit message.
  This is most conveniently done by using --signoff (-s) when running git commit.

Source: https://github.com/hyperledger-cacti/cacti/actions/runs/11819193500/job/32928793439

[krriscode]

Hi @petermetz,
I have check git config twice and it is correct, below is screenshot of it
I got stuck here, could you please help me to resolve this issue.

[petermetz]

@krriscode That's strange, let me take a look at it myself then. FYI: I'll probably end up rebasing your branch manually, so if you see divergence between your local branch and the remote branch that's no cause for alarm.

[petermetz]

@krriscode LGTM, thank you!

[petermetz]

@krriscode Upon further investigation it looks like you did manage to fix it after all, so we are good to go now we just need other maintainers to review it and then it can be merged. Thank you again for the contribution!