Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ghcr-example-supply-chain-app): fix missing patch @ionic-native #3651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zondervancalvez
Copy link
Contributor

Commit to be reviewed

test(ghcr-example-supply-chain-app): fix missing patch @ionic-native

Primary Changes
----------------
1. Updated the NVM version to 20.11.1 and added
the necessary yarn patch path to build the image

Fixes #3601

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Primary Changes
----------------
1. Updated the NVM version to 20.11.1 and added
the necessary yarn patch path to build the image

Fixes hyperledger-cacti#3601

Signed-off-by: bado <[email protected]>
@jagpreetsinghsasan
Copy link
Contributor

@zondervancalvez codegen is failing

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zondervancalvez Looking good in general but I have a few nits:

  1. If you need the NodeJS upgrade then please explain why. Otherwise remove it.
  2. The .yarn/ directory is 700 MB. The patch that is in it is only a few KB. Could you please try to only include the patch file with an otherwise empty .yarn/ directory so we don't have to increase the image size by this much just for the little patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(ghcr-example-supply-chain-app): fix missing patch @ionic-native
3 participants