[feature] #2627: Config finalisation #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
ilchu
force-pushed
the
finalize-config
branch
2 times, most recently
from
00f375a to
e47e093
Compare
Erigara
reviewed
Sep 7, 2022
ilchu
force-pushed
the
finalize-config
branch
from
9cee1dc to
33d48d9
Compare
appetrosyan
reviewed
Sep 14, 2022
appetrosyan
reviewed
Sep 14, 2022
appetrosyan
reviewed
Sep 14, 2022
This was referenced Sep 14, 2022
Closed
Closed
ilchu
force-pushed
the
finalize-config
branch
2 times, most recently
from
491ce02 to
bbef9d8
Compare
ilchu
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis and
pesterev
as code owners
ilchu
force-pushed
the
finalize-config
branch
4 times, most recently
from
7e18660 to
31e712e
Compare
github-actions
bot
added
the
config-changes
BAStos525
force-pushed
the
iroha2-dev
branch
from
598952f to
e9563bf
Compare
ilchu
force-pushed
the
finalize-config
branch
from
31e712e to
f5501f0
Compare
ilchu
force-pushed
the
finalize-config
branch
3 times, most recently
from
6432890 to
4cd3e3b
Compare
Erigara
previously approved these changes
Sep 21, 2022
appetrosyan
reviewed
Sep 21, 2022
appetrosyan
previously approved these changes
Sep 21, 2022
appetrosyan
force-pushed
the
finalize-config
branch
from
4cd3e3b to
c94b8c8
Compare
ilchu
force-pushed
the
finalize-config
branch
from
c94b8c8 to
f3ce8cd
Compare
appetrosyan
previously approved these changes
Sep 21, 2022
ilchu
force-pushed
the
finalize-config
branch
from
f3ce8cd to
71e8a84
Compare
appetrosyan
previously approved these changes
Sep 22, 2022
Erigara
reviewed
Sep 22, 2022
Erigara
previously approved these changes
Sep 22, 2022
ilchu
force-pushed
the
finalize-config
branch
from
71e8a84 to
8b73afa
Compare
Erigara
previously approved these changes
Sep 22, 2022
outoftardis
reviewed
Sep 22, 2022
outoftardis
reviewed
Sep 22, 2022
ilchu
force-pushed
the
finalize-config
branch
from
8b73afa to
47c18d8
Compare
outoftardis
reviewed
Sep 22, 2022
…-iroha#2614: Config finalisation, proxy entrypoint, kagami docgen Signed-off-by: Ilia Churin <[email protected]>
ilchu
force-pushed
the
finalize-config
branch
from
47c18d8 to
d915522
Compare
Erigara
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilia Churin [email protected]
Description of the Change
..Proxystructs haveDefaultimplsDocumentedtrait works on..Proxyas well for the sake ofkagamigenfinalize()methods reworked to be more comprehensiveplaceholder..()methods ditchedIssue
Closes #2627, #2589, #2614.
Benefits
Almost the final steps in the config epic, tests notwithstanding.
Possible Drawbacks
Still work needs to be done with the test network, as some old tests keep failing