-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[documentation]: remove auto-generated configuration reference #4127
Merged
0x009922
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
0x009922:remove-config-documentation
Dec 13, 2023
Merged
[documentation]: remove auto-generated configuration reference #4127
0x009922
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
0x009922:remove-config-documentation
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x009922
added
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Documentation
Documentation changes
config-changes
Changes in configuration and start up of the Iroha
labels
Dec 8, 2023
This was referenced Dec 8, 2023
Pull Request Test Coverage Report for Build 7188221761
💛 - Coveralls |
0x009922
changed the title
[docs] #0000: remove auto-generated configuration reference
[documentation]: remove auto-generated configuration reference
Dec 11, 2023
0x009922
changed the title
[documentation]: remove auto-generated configuration reference
[documentation]: remove auto-generated configuration reference (?)
Dec 11, 2023
0x009922
changed the title
[documentation]: remove auto-generated configuration reference (?)
[documentation]: remove auto-generated configuration reference
Dec 11, 2023
0x009922
force-pushed
the
remove-config-documentation
branch
from
December 12, 2023 09:21
a2cb97c
to
434411e
Compare
0x009922
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara and
DCNick3
as code owners
December 12, 2023 09:21
mversic
reviewed
Dec 12, 2023
mversic
approved these changes
Dec 12, 2023
DCNick3
reviewed
Dec 12, 2023
DCNick3
approved these changes
Dec 12, 2023
Signed-off-by: Dmitry Balashov <[email protected]>
0x009922
force-pushed
the
remove-config-documentation
branch
from
December 12, 2023 22:50
434411e
to
78a2c3d
Compare
mversic
approved these changes
Dec 13, 2023
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config-changes
Changes in configuration and start up of the Iroha
Documentation
Documentation changes
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes auto-generated configuration reference and everything related to it.
The motivation is to make one step forward towards the new reference (hyperledger-iroha/iroha-2-docs#392).
After merge of this PR, there will be no configuration reference available for some time. We decided that it is fine and will streamline further process according to the RFC (#2585).
Should be reviewed and merged after: