Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #4287: use algorithm in PrivateKey serialized form #4326

Merged

Conversation

0x009922
Copy link
Contributor

Description

Aligns serialized form of PrivateKey with its representation in Rust, i.e. rename digest_function to algorithm.

This change might cause compatibility issues, but let's consider them as a part of the overall breaking configuration change: #2585

Linked issue

Closes #4287

@0x009922 0x009922 added iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha UI Something about the interface crypto labels Feb 26, 2024
@0x009922 0x009922 self-assigned this Feb 26, 2024
@github-actions github-actions bot added the Bug Something isn't working label Feb 26, 2024
Copy link

@BAStos525

@0x009922 0x009922 removed the Bug Something isn't working label Feb 26, 2024
DCNick3
DCNick3 previously approved these changes Feb 26, 2024
Signed-off-by: Dmitry Balashov <[email protected]>
@coveralls
Copy link

coveralls commented Feb 26, 2024

Pull Request Test Coverage Report for Build 8056281809

Details

  • 0 of 73 (100.0%) changed or added relevant lines in 4 files are covered.
  • 3125 unchanged lines in 55 files lost coverage.
  • Overall coverage decreased (-0.3%) to 56.532%

Files with Coverage Reduction New Missed Lines %
core/src/sumeragi/network_topology.rs 1 98.78%
tools/kagami/src/crypto.rs 1 12.12%
data_model/src/metadata.rs 2 78.87%
primitives/src/unique_vec.rs 2 91.24%
config/src/kura.rs 3 80.0%
config/src/logger.rs 5 72.73%
logger/src/lib.rs 5 94.12%
tools/kagami/src/main.rs 5 0.0%
telemetry/src/dev.rs 7 0.0%
core/src/smartcontracts/isi/mod.rs 8 76.4%
Totals Coverage Status
Change from base Build 7884695009: -0.3%
Covered Lines: 22454
Relevant Lines: 39719

💛 - Coveralls

@0x009922 0x009922 merged commit fe2b301 into hyperledger-iroha:iroha2-dev Feb 27, 2024
12 checks passed
@0x009922 0x009922 deleted the 4287-algorithm-not-digest branch February 27, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-changes Changes in configuration and start up of the Iroha crypto iroha2-dev The re-implementation of a BFT hyperledger in RUST UI Something about the interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants