fix: Updated time events acc. to provided instructions #4779

hollermay · 2024-06-27T05:10:17Z

Description

This PR resolves issue number #4729

Before resolving:

After resolving the issue

Also, apart from this I made the required changes that involved changing of start to start_ms and since to since_ms.

Signed-off-by: Udayan Sharma <[email protected]>

data_model/src/events/time.rs

nxsaken · 2024-06-27T06:43:51Z

Please make sure you follow the contributing guide and use conventional commit messages with the present tense imperative mood. You also don't need to include screenshots of the proposed changes, as the diff provided by GitHub already does that.

…a#4759) Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.85 to 1.0.86. - [Release notes](https://github.com/dtolnay/proc-macro2/releases) - [Commits](dtolnay/proc-macro2@1.0.85...1.0.86) --- updated-dependencies: - dependency-name: proc-macro2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [syn](https://github.com/dtolnay/syn) from 2.0.66 to 2.0.68. - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.66...2.0.68) --- updated-dependencies: - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…a#4750) Signed-off-by: BAStos525 <[email protected]>

Signed-off-by: Marin Veršić <[email protected]>

Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.8.0 to 1.9.0. - [Release notes](https://github.com/uuid-rs/uuid/releases) - [Commits](uuid-rs/uuid@1.8.0...1.9.0) --- updated-dependencies: - dependency-name: uuid dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…yperledger-iroha#4719) * feat(swarm): reimplement, optimize compose config and its generation * feat(swarm): include args in banner, add option to print config to stdout * test(swarm): add tests, fix errors * docs(swarm): add note about config structure * fix(swarm): fix peer startup, don't use builder on pull, add local image to CI * refactor(swarm): clean up schema types * build(swarm): pass `GENESIS_PRIVATE_KEY` env var to containers * feat(swarm): update leader command, include full topology in leader's env --------- Signed-off-by: Nurzhan Sakén <[email protected]>

…rledger-iroha#4757) Signed-off-by: Dmitry Murzin <[email protected]>

…4742) Signed-off-by: Marin Veršić <[email protected]>

…ha#4771)

…ts (hyperledger-iroha#4772) Bumps [mypy](https://github.com/python/mypy) from 1.10.0 to 1.10.1. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.10.0...v1.10.1) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…yperledger-iroha#4768) Signed-off-by: omahs <[email protected]>

Co-authored-by: Nurzhan Saken <[email protected]> Signed-off-by: Udayan S. <[email protected]>

…ts (hyperledger-iroha#4776) Bumps [pylint](https://github.com/pylint-dev/pylint) from 3.2.3 to 3.2.4. - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v3.2.3...v3.2.4) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…yperledger-iroha#4777) Bumps [faker](https://github.com/joke2k/faker) from 25.9.1 to 25.9.2. - [Release notes](https://github.com/joke2k/faker/releases) - [Changelog](https://github.com/joke2k/faker/blob/master/CHANGELOG.md) - [Commits](joke2k/faker@v25.9.1...v25.9.2) --- updated-dependencies: - dependency-name: faker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: fix apply_block and validate_block benchmarks * fix: fix no_extra_or_missing_schemas * fix: derive Ord for AccountIdDomainCompare * fix: remove account permissions and roles with account * fix: decrease size of block validate_blocks and apply_blocks benchmars * bump: update storage crate Signed-off-by: Shanin Roman <[email protected]>

…rledger-iroha#4732) Signed-off-by: Stukalov-A-M <[email protected]>

Signed-off-by: Dmitry Murzin <[email protected]>

* remove `Fail` instruction * rename `Custom` to `CustomInstruction` * enable direct use of custom instructions Signed-off-by: Marin Veršić <[email protected]>

…yperledger-iroha#4785) Bumps [faker](https://github.com/joke2k/faker) from 25.9.2 to 26.0.0. - [Release notes](https://github.com/joke2k/faker/releases) - [Changelog](https://github.com/joke2k/faker/blob/master/CHANGELOG.md) - [Commits](joke2k/faker@v25.9.2...v26.0.0) --- updated-dependencies: - dependency-name: faker dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ger-iroha#4741) * rename Permission::id to Permission::name * rename AssetValueType to AssetType Signed-off-by: Marin Veršić <[email protected]>

Signed-off-by: Stukalov-A-M <[email protected]>

…iroha#4731) * remove `NewParameter` ISI * remove on-chain parameters from configuration * strong type on-chain parameters * removed `MetadataLimits` and `LenghtLimits` as built-in on-chain parameters * provide facility to define custom parameters in executor Signed-off-by: Marin Veršić <[email protected]>

github-actions · 2024-06-28T14:39:36Z

@BAStos525

…iroha#4731) * remove `NewParameter` ISI * remove on-chain parameters from configuration * strong type on-chain parameters * removed `MetadataLimits` and `LenghtLimits` as built-in on-chain parameters * provide facility to define custom parameters in executor Signed-off-by: Marin Veršić <[email protected]> Signed-off-by: hollermay <[email protected]>

…o convert-time

nxsaken · 2024-06-28T17:30:56Z

Thank you for your submission. However, there are several issues:

Compilation fails.
Tests and the rest of CI are failing.
Commits don't follow our guidelines.

I'm closing this PR for now. You're welcome to review the contributing guide, address these issues and resubmit. Thank you.

Updated time events acc. to provided instructions

d270a53

Signed-off-by: Udayan Sharma <[email protected]>

hollermay requested review from s8sato, mversic, SamHSmith, outoftardis, Erigara, 0x009922, DCNick3 and dima74 as code owners June 27, 2024 05:10

hollermay changed the title ~~fix: Updated time events acc. to provided instructions~~ fix:Updated time events acc. to provided instructions Jun 27, 2024

hollermay changed the title ~~fix:Updated time events acc. to provided instructions~~ fix: Updated time events acc. to provided instructions Jun 27, 2024

nxsaken suggested changes Jun 27, 2024

View reviewed changes

data_model/src/events/time.rs Outdated Show resolved Hide resolved

data_model/src/events/time.rs Outdated Show resolved Hide resolved

data_model/src/events/time.rs Outdated Show resolved Hide resolved

data_model/src/events/time.rs Outdated Show resolved Hide resolved

dependabot bot and others added 17 commits June 28, 2024 20:09

ci: Modify CodeQuality job branch checkout variable (hyperledger-iroh…

0809b44

…a#4750) Signed-off-by: BAStos525 <[email protected]>

fix: restore RawGenesisTransaction schema (hyperledger-iroha#4765)

d9e6f23

Signed-off-by: Marin Veršić <[email protected]>

fix!: Upgrade executor in separate transaction in genesis block (hype…

9eaf2ee

…rledger-iroha#4757) Signed-off-by: Dmitry Murzin <[email protected]>

refactor: move permission migration into executor (hyperledger-iroha#…

c86114f

…4742) Signed-off-by: Marin Veršić <[email protected]>

chore(deps): bump serde_json from 1.0.117 to 1.0.118 (hyperledger-iro…

b916773

…ha#4771)

docs(md): fix typos in CONTRIBUTING, iroha_2_whitepaper, hot-reload (h…

647462c

…yperledger-iroha#4768) Signed-off-by: omahs <[email protected]>

Update data_model/src/events/time.rs

f10a241

Co-authored-by: Nurzhan Saken <[email protected]> Signed-off-by: Udayan S. <[email protected]>

Update data_model/src/events/time.rs

b362807

Co-authored-by: Nurzhan Saken <[email protected]> Signed-off-by: Udayan S. <[email protected]>

Update data_model/src/events/time.rs

e4d8453

Co-authored-by: Nurzhan Saken <[email protected]> Signed-off-by: Udayan S. <[email protected]>

Update data_model/src/events/time.rs

3f0a79c

Co-authored-by: Nurzhan Saken <[email protected]> Signed-off-by: Udayan S. <[email protected]>

Erigara and others added 8 commits June 28, 2024 20:09

refactor: Make the metadata dynamic via implementing JsonString (hype…

5e2c420

…rledger-iroha#4732) Signed-off-by: Stukalov-A-M <[email protected]>

feat: Allow multiple peers submit genesis block (hyperledger-iroha#4775)

7fc7f71

Signed-off-by: Dmitry Murzin <[email protected]>

refactor: improve custom instruction usage (hyperledger-iroha#4778)

7e6909e

* remove `Fail` instruction * rename `Custom` to `CustomInstruction` * enable direct use of custom instructions Signed-off-by: Marin Veršić <[email protected]>

refactor!: fix naming convention for assets and permissions (hyperled…

26c00ab

…ger-iroha#4741) * rename Permission::id to Permission::name * rename AssetValueType to AssetType Signed-off-by: Marin Veršić <[email protected]>

refactor: Add #[ignore] to the sorting test (hyperledger-iroha#4786)

49c9a3c

Signed-off-by: Stukalov-A-M <[email protected]>

hollermay force-pushed the convert-time branch from 222ec4e to 0249a8a Compare June 28, 2024 14:39

github-actions bot added api-changes Changes in the API for client libraries config-changes Changes in configuration and start up of the Iroha labels Jun 28, 2024

hollermay and others added 3 commits June 28, 2024 20:38

Merge branch 'convert-time' of https://github.com/hollermay/iroha int…

11af9de

…o convert-time

Merge branch 'main' into convert-time

47d6ab1

nxsaken closed this Jun 28, 2024

hollermay deleted the convert-time branch July 1, 2024 15:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Updated time events acc. to provided instructions #4779

fix: Updated time events acc. to provided instructions #4779

hollermay commented Jun 27, 2024 •

edited

Loading

nxsaken commented Jun 27, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024

nxsaken commented Jun 28, 2024

fix: Updated time events acc. to provided instructions #4779

fix: Updated time events acc. to provided instructions #4779

Conversation

hollermay commented Jun 27, 2024 • edited Loading

Description

Before resolving:

After resolving the issue

nxsaken commented Jun 27, 2024 • edited Loading

github-actions bot commented Jun 28, 2024

nxsaken commented Jun 28, 2024

hollermay commented Jun 27, 2024 •

edited

Loading

nxsaken commented Jun 27, 2024 •

edited

Loading