-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7840 Implementation #8042
EIP-7840 Implementation #8042
Conversation
Signed-off-by: Simon Dudley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so far so good, possible bug in osaka setup.
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
// * @param parentBlobGasUsed blob gas used from the parent | ||
// * @return the new excess blob gas value | ||
// */ | ||
// default long computeExcessBlobGas( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assume this all gets deleted after coming out of draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
...e/src/main/java/org/hyperledger/besu/ethereum/mainnet/CancunTargetingGasLimitCalculator.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Dudley <[email protected]>
…or each fork This isolates defaulting to MainnetProtocolSpecs and reduces blast radius for tests Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
- Add asMap for blobSchedule so it appears in admin_nodeInfo - Prememptively add OsakaTargetingGasLimitCalculator and wire in the max blob count Add blobschedule to mainnet.json to be explicit, since the code will default to the same values anyway Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
config/src/main/java/org/hyperledger/besu/config/BlobScheduleOptions.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/hyperledger/besu/ethereum/mainnet/OsakaTargetingGasLimitCalculator.java
Outdated
Show resolved
Hide resolved
…net/OsakaTargetingGasLimitCalculator.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Simon Dudley <[email protected]>
…ptions.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Drive Cancun, Prague and Osaka target and max blobs per block from genesis config. If blobSchedule is missing, use the mainnet default values. Target is wired into appropriate *GasCalculator implementations. Max is wired into appropriate *TargetingGasLimitCalculator implementations. --------- Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
PR description
Drive Cancun, Prague and Osaka target and max blobs per block from genesis config:
If blobSchedule is missing, use the mainnet default values, i.e. same as config above.
Target is wired into appropriate *GasCalculator implementations
Max is wired into appropriate *TargetingGasLimitCalculator implementations
This PR does not remove EIP-7742 (although overlaps slightly)
This has been tested with a local pectra interop and successfully produced and validated blocks containing up to 9 blobs.
2024-12-19 02:42:22.551+00:00 | vert.x-worker-thread-0 | INFO | AbstractEngineNewPayload | Imported #34 (8c3c2.....3c8e7)| 58 tx| 0 ws| 9 blobs| base fee 17.89 mwei| gas used 2,390,426 ( 8.0%)| exec time 0.010s| mgas/s 239.04| peers: 2
Fixed Issue(s)
#8026
ethereum/EIPs#9129
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests