-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeployContract implementation for Tezos connector #36
Conversation
Signed-off-by: Alexey Semenyuk <[email protected]>
Signed-off-by: Alexey Semenyuk <[email protected]>
Signed-off-by: Alexey Semenyuk <[email protected]>
Signed-off-by: Alexey Semenyuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this file doesn't have coverage TODO add this at next PR
Signed-off-by: Alexey Semenyuk <[email protected]>
f4d86a5
to
40c82b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 63.70% 62.43% -1.28%
==========================================
Files 22 22
Lines 912 969 +57
==========================================
+ Hits 581 605 +24
- Misses 325 358 +33
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@alex-semenyuk If I am reading this correctly, for Tezos, the code (instructions) are bound up in the same object as the type definitions for a smart contract. Am I understanding that correctly? I'm just thinking through if we're using the right fields here. For ethereum contracts, the compiled code and the interface are entirely separate things, and have separate fields on FireFly's API but maybe that doesn't make sense with Tezos. |
@nguyer |
Related PRs to firefly and firefly-cli
Request example
Response