Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align the credential schema property name according to the VCDM 1.1 #1467

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Nov 28, 2024

Description:

  • deprecated the filed schemaId and created the alternative that is aligned with the specification (JWT/SD-JWT/AnonCreds)
  • added requirement to add the schemaId property to the create credential offer request for JWT/SD-JWT VC
  • added credentialSchema property that is aligned with VCDM 1.1 to the domain and HTTP layers

In the next iteration, the new HTTP client will be generated and additional e2e tests will be added.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

…m1_1

# Conflicts:
#	tests/integration-tests/src/test/kotlin/common/CredentialSchema.kt
#	tests/integration-tests/src/test/kotlin/steps/connectionless/ConnectionLessSteps.kt
#	tests/integration-tests/src/test/kotlin/steps/credentials/JwtCredentialSteps.kt
#	tests/integration-tests/src/test/resources/features/credential/jwt/issuance.feature
#	tests/integration-tests/src/test/resources/features/credential/sdjwt/issuance.feature
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) November 28, 2024 16:38
Copy link
Contributor

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
56 tests ±0  56 ✅ ±0  0 💤 ±0  0 ❌ ±0 
98 runs  ±0  98 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f1ea1c9. ± Comparison against base commit 5ece0dd.

Copy link
Contributor

Unit Test Results

104 files  ±0  104 suites  ±0   20m 9s ⏱️ +43s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit f1ea1c9. ± Comparison against base commit 5ece0dd.

@coveralls
Copy link

Coverage Status

coverage: 48.733% (-0.1%) from 48.859%
when pulling f1ea1c9 on feat/vcdm1_1
into 5ece0dd on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants