feat: castor create signed prism did operation #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elribonazo
force-pushed
the
features/issuer-poc
branch
3 times, most recently
from
587501a to
27f5263
Compare
elribonazo
force-pushed
the
features/issuer-poc
branch
3 times, most recently
from
1a58c32 to
a238d85
Compare
…stor Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
elribonazo
force-pushed
the
features/issuer-poc
branch
from
9c311ef to
460d9a9
Compare
|
Pull Request Test Coverage Report for Build 12161414747Details
💛 - Coveralls |
curtis-h
reviewed
Dec 11, 2024
| interface ProcessEnv { | ||
| NEXT_PUBLIC_BLOCKFROST_API_KEY: string; | ||
| } | ||
| } |
There was a problem hiding this comment.
not sure this belongs on the project root, isn't it demo specific?
| * @param {PublicKey[]} issuanceKeys | ||
| * @returns {Promise<{operationHex: string, metadataBody: {v: number, c: string[]}, did: DID}>} | ||
| */ | ||
| async createOperation( |
There was a problem hiding this comment.
can we improve this name? "Operation" feels a bit vague?
| const stateHashHex = Buffer.from(encodedStateHash).toString("hex"); | ||
| const base64State = base64.base64url.baseEncode(encodedState); | ||
| const methodSpecificId = PrismDID.parseMethodId([stateHashHex, base64State]); | ||
| const did = new DID("did", "prism", methodSpecificId.toString()); |
There was a problem hiding this comment.
if we're returning a prismDID shouldn't the createPrismDID function handle that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implemented sign operation in castor, which enables the SDK to create and publish a prism did using cip-30, any wallet really out there can now sign this operations and publish them onchain.
Also fixed wrong signatures in Apollo, we were not able to create a proper DER encoded secp256k1 signature, causing an issue on publishing the transaction.
published did in mainnet here
Checklist: