Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tls Notary Iexec #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erazhu31
Copy link
Contributor

@erazhu31 erazhu31 commented Sep 6, 2019

Tls Notary

Copy link
Member

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope - This is not TLS Notary

values[id].oracleCallID = _oracleCallID;
values[id].result = result;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes no sens. The whole purpose of an oracle is to get a unknown result. If the result is stored at keccak256(result) then you have to know the hash to access the value.

The ValueUpdated made sens in the context of the example (pricefeed) where an index can be updated. Are you expecting for values[id].result to be non-null it would have to contain a string which hash is the same as result's ...

process.stdout.write(`Failled to verify results (${reason})\n`);
});
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file makes sens for the pricefeed, but is completelly useless here. Either update it to you oracle or remove it!

console.log(certificate)

});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't get the point of what TLS Notary is ... at all

You are retreiving a certificat and pushing in onchain as a stringified json file. A smart contract cannot process that.
The concept of TLS notary is, given an URL, to:

  • Retrieve the file at the URL
  • While doing so, audit the ssl channel to provide cryptographic proof the file was retreived by this channel
  • Format the proof so that an external auditor can check it
  • Upload the file (or hash of file) and the proof

Just providing a certificate achieves nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants