added bank card payment app #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomasvangurp your commit seems to be empty? Thanks to update it :) |
|
@thomasvangurp any update? thanks |
|
@sulliwane yes, the app was not added as it was only symlinked! should work now |
thomasvangurp
changed the title
Amxx
requested changes
Nov 5, 2019
There was a problem hiding this comment.
I see 2 paas here:
- bank_card_payment
- weather_api
Both are not following the iExec Oracle methodology. Results should not just be printed out to the console, they have to be encoded properly and written to the correct file in order to pass the poco verification and be pushed to the blockchain in a format that can be processed by smart contracts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be functional. please let me know if any changes are expected