Fix start scripts (#1053)

* Rename cjs-package.mjs to package-cjs.mjs

* package-cjs to create dir if needed

* Move scripts around start script continues to work in watch mode

* rush change

apps/test-app/package.json

@@ -8,9 +8,9 @@
   "homepage": "http://localhost:3000/",
   "scripts": {
     "build": "npm run build:backend && npm run build:frontend",
-    "build:backend": "tsc -p tsconfig.backend.json && npm run build:backend:post",
-    "build:backend:post": "node ../../common/scripts/cjs-package.mjs ./lib",
+    "build:backend": "npm run package:cjs && tsc -p tsconfig.backend.json",
     "build:frontend": "npm run copy:webfont && npm run pseudolocalize && vite build",
+    "package:cjs": "node ../../common/scripts/package-cjs.mjs ./lib",
     "preview": "vite preview --port 3000",
     "clean": "rimraf lib build dist .rush/temp/package-deps*.json",
     "electron": "run-p start:webserver start:electron",

common/changes/@itwin/appui-react/fix-start_2024-09-27-08-21.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/appui-react",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/appui-react"
+}

common/changes/@itwin/components-react/fix-start_2024-09-27-08-21.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/components-react",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/components-react"
+}

common/changes/@itwin/core-react/fix-start_2024-09-27-08-21.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/core-react",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/core-react"
+}

common/changes/@itwin/imodel-components-react/fix-start_2024-09-27-08-21.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/imodel-components-react",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/imodel-components-react"
+}

common/scripts/cjs-package.mjs → common/scripts/package-cjs.mjs

@@ -10,7 +10,10 @@ const packageDir = path.join(process.cwd(), relativeDir);
 const filePath = path.join(packageDir, "package.json");
 
 try {
-  fs.writeFileSync(filePath, '{ "type": "commonjs" }');
+  if (!fs.existsSync(packageDir)) {
+    fs.mkdirSync(packageDir, { recursive: true });
+  }
+  fs.writeFileSync(filePath, '{ "type": "commonjs" }', {});
 } catch (e) {
   console.error("Cannot create package.json", e);
 }

ui/appui-react/package.json

@@ -27,9 +27,9 @@
   "scripts": {
     "start": "run-p -l \"build:** -- -w\" \"copy:** -- -w\"",
     "build": "npm run -s copy:locale && npm run -s build:cjs && npm run -s build:esm",
-    "build:cjs": "npm run -s copy:cjs && tsc -p tsconfig.cjs.json && npm run -s build:cjs:post",
-    "build:cjs:post": "node ../../common/scripts/cjs-package.mjs ./lib/cjs",
+    "build:cjs": "npm run -s copy:cjs && npm run -s package:cjs && tsc -p tsconfig.cjs.json",
     "build:esm": "npm run -s copy:esm && tsc -p tsconfig.esm.json",
+    "package:cjs": "node ../../common/scripts/package-cjs.mjs ./lib/cjs",
     "copy:cjs": "cpx \"./src/**/*.{*css,json,svg}\" \"./lib/cjs\"",
     "copy:esm": "cpx \"./src/**/*.{*css,json,svg}\" \"./lib/esm\"",
     "copy:locale": "cpx ./src/appui-react/UiFramework.json ./lib/public/locales/en",

ui/components-react/package.json

@@ -27,9 +27,9 @@
   "scripts": {
     "start": "run-p -l \"build:** -- -w\" \"copy:** -- -w\"",
     "build": "npm run -s copy:locale && npm run -s build:cjs && npm run -s build:esm",
-    "build:cjs": "npm run -s copy:cjs && tsc 1>&2 --outDir lib/cjs && npm run -s build:cjs:post",
-    "build:cjs:post": "node ../../common/scripts/cjs-package.mjs ./lib/cjs",
+    "build:cjs": "npm run -s copy:cjs && npm run -s package:cjs && tsc 1>&2 --outDir lib/cjs",
     "build:esm": "npm run -s copy:esm && tsc 1>&2 --module ES2020 --outDir lib/esm",
+    "package:cjs": "node ../../common/scripts/package-cjs.mjs ./lib/cjs",
     "copy:cjs": "cpx \"./src/**/*.*css\" ./lib/cjs",
     "copy:esm": "cpx \"./src/**/*.*css\" ./lib/esm",
     "copy:locale": "cpx ./src/components-react/UiComponents.json ./lib/public/locales/en",

ui/core-react/package.json

@@ -27,9 +27,9 @@
   "scripts": {
     "start": "run-p -l \"build:** -- -w\" \"copy:** -- -w\"",
     "build": "npm run -s copy:locale && npm run -s build:cjs && npm run -s build:esm",
-    "build:cjs": "npm run -s copy:cjs && tsc 1>&2 --outDir lib/cjs && npm run -s build:cjs:post",
-    "build:cjs:post": "node ../../common/scripts/cjs-package.mjs ./lib/cjs",
+    "build:cjs": "npm run -s copy:cjs && npm run -s package:cjs && tsc 1>&2 --outDir lib/cjs",
     "build:esm": "npm run -s copy:esm && tsc 1>&2 --module ES2020 --outDir lib/esm",
+    "package:cjs": "node ../../common/scripts/package-cjs.mjs ./lib/cjs",
     "copy:cjs": "cpx \"./src/**/*.{*css,svg}\" ./lib/cjs",
     "copy:esm": "cpx \"./src/**/*.{*css,svg}\" ./lib/esm",
     "copy:locale": "cpx ./src/core-react/UiCore.json ./lib/public/locales/en",

ui/imodel-components-react/package.json

@@ -27,9 +27,9 @@
   "scripts": {
     "start": "run-p -l \"build:** -- -w\" \"copy:** -- -w\"",
     "build": "npm run -s copy:locale && npm run -s build:cjs && npm run -s build:esm",
-    "build:cjs": "npm run -s copy:cjs && tsc 1>&2 --outDir lib/cjs && npm run -s build:cjs:post",
-    "build:cjs:post": "node ../../common/scripts/cjs-package.mjs ./lib/cjs",
+    "build:cjs": "npm run -s copy:cjs && npm run -s package:cjs && tsc 1>&2 --outDir lib/cjs",
     "build:esm": "npm run -s copy:esm && tsc 1>&2 --module ES2020 --outDir lib/esm",
+    "package:cjs": "node ../../common/scripts/package-cjs.mjs ./lib/cjs",
     "copy:cjs": "cpx \"./src/**/*.*css\" ./lib/cjs",
     "copy:esm": "cpx \"./src/**/*.*css\" ./lib/esm",
     "copy:locale": "cpx ./src/imodel-components-react/UiIModelComponents.json ./lib/public/locales/en",