Add ToolUtilities to define tool icon as a React element
#1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saskliutas
approved these changes
Dec 11, 2024
|
@Mergifyio backport release/5.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Add ToolUtilities * Update Tool types to include iconElement property. * NextVersion.md * Add note * Extract API * Add unit tests * Update test * rush change * Update snaps (cherry picked from commit 87ca8e3) # Conflicts: # docs/changehistory/NextVersion.md # ui/appui-react/src/appui-react/toolbar/ToolbarItemUtilities.tsx
GerardasB
added a commit
that referenced
this pull request
Dec 11, 2024
…1150) (#1152) * Add `ToolUtilities` to define tool icon as a React element (#1150) * Add ToolUtilities * Update Tool types to include iconElement property. * NextVersion.md * Add note * Extract API * Add unit tests * Update test * rush change * Update snaps (cherry picked from commit 87ca8e3) # Conflicts: # docs/changehistory/NextVersion.md # ui/appui-react/src/appui-react/toolbar/ToolbarItemUtilities.tsx * Fix merge issues --------- Co-authored-by: GerardasB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
ToolUtilities.defineIconhelper that defines an icon as a React element for a given ToolType.For additional information and usage notes see
NextVersion.mdTesting
Added additional unit tests and tested via test-app.