Add ModalFrontstageButton component
#1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport release/5.0.x |
✅ Backports have been created
|
|
Instead/in addition to this, is it possible to add a 'onBeforeExit' kind of event on the button click which users can handle via their provided function, and are able to cancel the back button operation if required. |
You can do that in a custom |
|
This story looks exactly like my use case. |
saskliutas
approved these changes
Dec 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Ability to override backButton of a modal frontstage. * Add ModalFrontstageButton * Remove unused BackButton * rush change * NextVersion.md * Extract API * Update snaps (cherry picked from commit b8a94f9) # Conflicts: # docs/changehistory/NextVersion.md # ui/appui-react/src/appui-react/layout/widget/tools/button/Back.tsx
GerardasB
added a commit
that referenced
this pull request
Dec 16, 2024
* Add `ModalFrontstageButton` component (#1156) * Ability to override backButton of a modal frontstage. * Add ModalFrontstageButton * Remove unused BackButton * rush change * NextVersion.md * Extract API * Update snaps (cherry picked from commit b8a94f9) # Conflicts: # docs/changehistory/NextVersion.md # ui/appui-react/src/appui-react/layout/widget/tools/button/Back.tsx * Merge conflicts. --------- Co-authored-by: GerardasB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds
backButtonproperty toModalFrontstageInfointerface to allow specifying of a custom back button for a modal frontstage. AdditionallyModalFrontstageButtoncomponent is added to maintain visual consistency between modal frontstages.ModalFrontstageButtonuses iTwinUIIconButtoninstead of outdated custom implementation.Additionally,
ModalFrontstageButtonis used as a default back button if nobackButtonis provided viaModalFrontstageInfo.Testing
Added additional story.