oidc-signin-tool: log signin retries #256
Conversation
paulius-valiunas
requested review from
calebmshafer,
evelynpreslar-bentley,
aruniverse,
ben-polinsky,
anmolshres98 and
MichaelSwigerAtBentley
as code owners
| @@ -31,28 +31,28 @@ | |||
| "directory": "packages/browser" | |||
| }, | |||
| "dependencies": { | |||
| "@itwin/core-common": "^3.7.0 || ^4.0.0", | |||
| "@itwin/core-common": "^4.9.1", | |||
There was a problem hiding this comment.
Similar changes exist in other packages.
There was a problem hiding this comment.
I just ran pnpm update and this happened... this should probably be a peerDependency. Having a wide range in dependencies doesn't guarantee it will be shared with the parent package, most likely pnpm would just install 4.9.1 even with the current version range.
There was a problem hiding this comment.
I just looked through the source and found that only a type is imported from this package, so it should definitely be a devDependency, or a peerDependency... but definitely not a direct dependency. Either way, this change does not affect consumers in any way, because as I said, pnpm would pick the latest version in that range anyway.
|
@paulius-valiunas my attempts to fix the integration tests in #257 have not gone as planned. I'll keep at it tomorrow |
No description provided.