-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Backend Functionality for Service Authorization #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklbh
requested review from
aruniverse,
ben-polinsky,
anmolshres98 and
MichaelSwigerAtBentley
as code owners
November 19, 2024 18:07
hl662
reviewed
Nov 19, 2024
franklbh
changed the title
Frank/backend service auth
Enhanced Backend Functionality for Service Authorization
Nov 19, 2024
aruniverse
reviewed
Nov 19, 2024
aruniverse
reviewed
Nov 19, 2024
hl662
reviewed
Nov 19, 2024
aruniverse
reviewed
Nov 19, 2024
hl662
approved these changes
Nov 19, 2024
aruniverse
approved these changes
Nov 19, 2024
…ients into Frank/backend-service-auth
ben-polinsky
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure what the pipeline failure is about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new backend function authClient that:
Accepts an oidcConfig object with clientId, clientSecret, scope, and optional authority.
Instantiates a ServiceAuthorizationClient using the provided configuration.
Fetches an access token using the client credentials flow and returns it.
Registered the new backend function with registerBackendCallback under the name "getServiceAuthToken"