-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage tooling and Coveralls workflow #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackson-at-bentley can you please elaborate on "Jason is okay with giving me the keys key to the repository for a day I'd like to finish setting it up (authenticating with Coveralls and adding the Coveralls account as a collaborator so it can leave coverage comments)." ? Feel free to provide links to relevant coveralls documentation. By keys to repo, it sounds like you can't do what is necessary via pull request or your current (write) access?
@jchick-bentley I was enjoying the imagery of joyriding the repository around. Here's the steps I took on my fork to get Coveralls working.
|
Ok - let's complete this PR w/o taking those extra steps. Seems like I have to grant access to all of iTwin rather than just our repo that's using it. I'll seek approval from someone who can speak for all of iTwin. |
@akshay-madhukar @admccarthy1 can we please get one more reviewer before we merge? |
sorry about the delay, I didn't see the email this morning because my internet is out (again) but looks good to me. |
What's the dependency policy? I don't know how to force reproducible builds with |
$ npm run test:standalone
I chose
nyc
because other projects at Bentley likeecschema2ts
use it. If I configured everything correctly, the synchronizer has about 40 percent line coverage.This is a breaking PR, but I don't think any projects depend on the v3I've reverted the breaking API change in #45, which I'm closing because I can't run the Azure pipeline on the fork. My "fix" is hardcoding the path to the test connector's schema, because@itwin/connector-framework
yet.__dirname
's value inKnownTestLocations
changes when running JIT withts-node
and when beingrequire
'ed.mocha-suppress-logs
to suppress theLogger
output.mocha
happy.test
is now in the root directory.To address
nyc
, but the text reporter works as shown above. (I've downgradedts-node
.)npm run test:connector
is failing withfetch is not defined
. That code hasn't changed, and isn't covered by the tests [Figure 1].npm run test:integration
is failing only on Linux withFailed OIDC signin. Looks like something is not right. Please contact your administrator. 400 - Invalid client_id
. There's this very suspicious comment inoicd-signin-tool
[Figure 2]. This also happens on themain
branch on Linux.test
directory because of thets-node
JIT tooling, but I'm not sure how else to configurenyc
, because parts of that directory need to be compiled.I've never configured coverage tooling before so I welcome any and all feedback.
What's next
coveralls
for visibility.Figures
Figure 1
Figure 2