Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework
applySavedView
settings interface to make it easier to understand.Initially I designed it around the idea of extensions having three three operations: save, apply, and reset. While this system worked well for some applications, this confined the interface to a narrow applicability space and burdened users with a mental model that didn't necessarily match their expectations. This change is a step towards rethinking what it means to "apply a saved view", and making built-in
EmphasizeElements
andPerModelCategoryVisibility
extensions first-class concepts ofsaved-views-react
.Breaking changes
applySavedView
settings easier to understand"reset"
fromApplyStrategy
union, instead make"clear"
a valid value foremphasis
andperModelCategoryVisibility
propertiesall
property which set defaultApplyStrategy
of all settingsMinor changes
applySavedView
enhancementsviewChangeOptions
that the function will internally pass through toviewport.changeView
callcamera
setting that controls how camera data is applied. Allow supplying a customViewPose
or ignoring Saved View data to keep the camera in place.Other
savedviews:read
andsavedviews:modify
because they have been superseded byitwin-platform
scopeexecuteQuery
use by making it return a flat list of ids