Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focusing a screen when the screen has no windows. #749

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Lukas-Stuehrk
Copy link
Contributor

I'm unsure about the naming of the cgRect method. Please feel free to suggest a better name.

Resolves #533

@ianyh
Copy link
Owner

ianyh commented Aug 31, 2018

The naming seems fine for now, but I tested this and it doesn't seem to solve the problem. That function never gets called. It looks like something in this function is failing to focus the screen when there are no windows. https://github.com/ianyh/Amethyst/blob/development/Amethyst/Managers/WindowModifier.swift#L287

@Lukas-Stuehrk
Copy link
Contributor Author

Interesting....gets called for me at https://github.com/ianyh/Amethyst/blob/development/Amethyst/Managers/WindowModifier.swift#L307 in exactly this method.

macOS 10.13.6 (17G65) with neither mff nor ffm activated.

@ianyh
Copy link
Owner

ianyh commented Sep 1, 2018

So I think it's actually this line https://github.com/ianyh/Amethyst/blob/development/Amethyst/Managers/WindowModifier.swift#L293

There is a focused window, but it's on a different screen. I seem to hit that condition when trying to focus a screen with no windows. I'm not sure why it's only happening to me on your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants