This repository has been archived by the owner on Jul 21, 2022. It is now read-only.
Rename GitHubCity's Properties #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 28, 2017
| @@ -410,10 +410,10 @@ def getSortedUsers(self, order="public"): | |||
| :rtype: str. | |||
| """ | |||
| try: | |||
| self.__dataUsers.sort(key=lambda u: getattr(u, order), reverse=True) | |||
| self.__processedUsers.sort(key=lambda u: getattr(u, order), reverse=True) | |||
There was a problem hiding this comment.
line too long (85 > 79 characters)
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 35.29% 35.29%
=======================================
Files 3 3
Lines 527 527
=======================================
Hits 186 186
Misses 341 341
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This issue with the current property names presents the opportunity for confusion of code or documentation. This will hopefully prevent that issue.
Approach
The original property identities have been reformatted to a more understanding naming convention; as regulated by the ticket provided.
New Issues/FIXME?
No new issues to be documented
Learning
No findings to be documented