Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove evaluation-dependent code, address a CVE #93

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

ssiegel95
Copy link
Collaborator

@ssiegel95
Copy link
Collaborator Author

I guess since we have tsfmhfdemos in our package list we need to find a better solution than just removing that directory. I'll revert that commit.

packages = [
    "tsfm_public",
    "tsfm_public.toolkit",
    "tsfm_public.models",
    "tsfm_public.models.tinytimemixer",
    "tsfm_public.models.tinytimemixer.utils",
    "tsfmhfdemos",
    "tsfmhfdemos.neurips",
    "tsfmhfdemos.neurips.backends",
    "tsfmhfdemos.neurips.backends.v1",
    "tsfmhfdemos.neurips.backends.v1.figures",
]

@wgifford
Copy link
Collaborator

Hi Stuart -- a few weeks ago we addressed the CVE by requiring >= 1.26.19. (CVE can be addressed by either version 1.26.19 or version 2.2.2.) I think there was another dependency that required < 2 -- possibly this is changed now with a later version of transformers and/or datasets?

@ssiegel95
Copy link
Collaborator Author

Okay, I'll make that change.

@wgifford wgifford self-requested a review July 31, 2024 21:17
@wgifford wgifford merged commit 728f030 into ibm-granite:main Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants