Add checks in Provider put() method in Java Security Restricted Mode #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keithc-ca This is a back port PR from JDKNext PR ibmruntimes/openj9-openjdk-jdk#610. Please help to review. |
|
Please expand the commit message (see ibmruntimes/openj9-openjdk-jdk#610 (comment)). |
taoliult
force-pushed
the
fips
branch
2 times, most recently
from
c2cab3d to
a37afc9
Compare
|
See https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines for expectations of commit messags. In particular note the advice that the "body should be wrapped at 72 characters", and that the "Signed-off-by:" line should follow the body. |
The legacy “put()” method is for adding the services and it is used by provider SUN and SunEC in Semeru OpenJDK8. From OpenJDK11 and above versions, all those usages of “put()” method changed to "putService()" method. But we still need to check the services which are added by the legacy “put()” method in Java Security Restricted Mode. So, updated the codes in Provider.java for checking the registered services, only allowed the needed services be stored in the "legacyMap". And this commit also added more debug info in Java Security Restricted Mode. Signed-off-by: Tao Liu <[email protected]>
|
@keithc-ca Sorry about the commit messages. I wrapped the body at 72 characters for each line and also move the "Signed-off-by:" line follow the body. Please help to review. |
|
Jenkins test sanity.openjdk amac jdk21 |
keithc-ca
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tao Liu [email protected]
This is a back port PR from JDKNext PR ibmruntimes/openj9-openjdk-jdk#610
This PR is for adding the services check in Provider legacy "put()" method and debug info in Java Security Restricted Mode.
The legacy “put()” method is for adding the services and it is used by provider SUN and SunEC in Semeru OpenJDK8. From OpenJDK11 and above versions, all those usages of “put()” method changed to "putService()" method. But we still need to check the services which are added by the legacy “put()” method in Java Security Restricted Mode. So, updated the codes for checking the registered services, only allowed the needed services be stored in the "legacyMap".