fixed hole in unit test and windows test

ic3man5 · Aug 15, 2023 · 8297cfe · 8297cfe
1 parent 09e0d30
commit 8297cfe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/ice_library.cpp b/src/ice_library.cpp
@@ -65,7 +65,7 @@ Library::Library(std::string name, bool nothrow)
         LocalFree(buffer);
         m_last_error = err.str();
         m_has_error = true;
-        if (m_nothrow) {
+        if (!m_nothrow) {
             throw Exception(err.str());
         }
     }

diff --git a/tests/test_ice_library.cpp b/tests/test_ice_library.cpp
@@ -115,8 +115,8 @@ TEST_CASE("LibraryManagerBasic", "[librarymanager]")
     REQUIRE(library->_library() != NULL);
     // Test a failure library being added
     try {
-        mgr.add("failure", "This_Should_Always_Fail", true);
-        // auto failure_library = ice::Library("This_Should_Always_Fail");
+        mgr.add("failure", "This_Should_Always_Fail", false);
+        REQUIRE(false);
     } catch (ice::Exception& ex) {
         auto error_msg = ex.whatString();
         INFO(error_msg);