Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a meaningful error message if the IngestReader input fails XSD validation #151

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

RKrahl
Copy link
Member

@RKrahl RKrahl commented Mar 20, 2024

Call XMLSchema().assertValid() rather than XMLSchema().validate() which raises a more meaningful error message. Pass that error message in the InvalidIngestFileError raised by IngestReader. As a result a much more meaningful error message is provided than a plain "Invalid ingest file: validation failed".

@RKrahl RKrahl added the enhancement New feature or request label Mar 20, 2024
@RKrahl RKrahl added this to the 1.3.0 milestone Mar 20, 2024
@RKrahl RKrahl merged commit 27ef917 into develop Mar 20, 2024
1 check passed
@RKrahl RKrahl deleted the xml-validate branch March 20, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant