fix: improve 2fa delete input step padding

ice-blockchain · Jan 2, 2025 · 89dbab4 · 89dbab4
1 parent 9c6ff28
commit 89dbab4
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 30 deletions.
diff --git a/...nticator/views/pages/delete_authenticator/components/delete_authenticator_input_step.dart b/...nticator/views/pages/delete_authenticator/components/delete_authenticator_input_step.dart
@@ -21,6 +21,7 @@ class DeleteAuthenticatorInputStep extends ConsumerWidget {
       headerTitle: locale.authenticator_delete_title,
       headerDescription: locale.authenticator_delete_description,
       headerIcon: Assets.svg.iconWalletProtectFill.icon(size: 36.0.s),
+      contentPadding: 8.0.s,
       child: DeleteTwoFAInputStep(
         twoFaToDelete: TwoFaType.auth,
         onDeleteSuccess: () => AuthenticatorDeleteSuccessRoute().push<void>(context),

diff --git a/lib/app/features/protect_account/components/delete_twofa_input_step.dart b/lib/app/features/protect_account/components/delete_twofa_input_step.dart
@@ -51,35 +51,38 @@ class DeleteTwoFAInputStep extends HookConsumerWidget {
         key: formKey.value,
         child: CustomScrollView(
           slivers: [
-            SliverList.builder(
-              itemCount: twoFaTypes.length,
-              itemBuilder: (context, index) {
-                final twoFaType = twoFaTypes[index];
-                return Padding(
-                  padding: EdgeInsets.only(bottom: 22.0.s),
-                  child: TwoFaCodeInput(
-                    controller: controllers[twoFaType]!,
-                    twoFaType: twoFaType,
-                    onRequestCode: () async {
-                      await guardPasskeyDialog(
-                        ref.context,
-                        (child) => RiverpodVerifyIdentityRequestBuilder(
-                          provider: requestTwoFaCodeNotifierProvider,
-                          requestWithVerifyIdentity:
-                              (OnVerifyIdentity<GenerateSignatureResponse> onVerifyIdentity) {
-                            ref.read(requestTwoFaCodeNotifierProvider.notifier).requestTwoFaCode(
-                                  twoFaType,
-                                  onVerifyIdentity,
-                                );
-                          },
-                          child: child,
-                        ),
-                      );
-                    },
-                    isSending: isRequesting,
-                  ),
-                );
-              },
+            SliverPadding(
+              padding: EdgeInsets.only(top: 56.0.s),
+              sliver: SliverList.builder(
+                itemCount: twoFaTypes.length,
+                itemBuilder: (context, index) {
+                  final twoFaType = twoFaTypes[index];
+                  return Padding(
+                    padding: EdgeInsets.only(bottom: 22.0.s),
+                    child: TwoFaCodeInput(
+                      controller: controllers[twoFaType]!,
+                      twoFaType: twoFaType,
+                      onRequestCode: () async {
+                        await guardPasskeyDialog(
+                          ref.context,
+                          (child) => RiverpodVerifyIdentityRequestBuilder(
+                            provider: requestTwoFaCodeNotifierProvider,
+                            requestWithVerifyIdentity:
+                                (OnVerifyIdentity<GenerateSignatureResponse> onVerifyIdentity) {
+                              ref.read(requestTwoFaCodeNotifierProvider.notifier).requestTwoFaCode(
+                                    twoFaType,
+                                    onVerifyIdentity,
+                                  );
+                            },
+                            child: child,
+                          ),
+                        );
+                      },
+                      isSending: isRequesting,
+                    ),
+                  );
+                },
+              ),
             ),
             SliverFillRemaining(
               hasScrollBody: false,

diff --git a/lib/app/features/protect_account/components/delete_twofa_step_scaffold.dart b/lib/app/features/protect_account/components/delete_twofa_step_scaffold.dart
@@ -15,13 +15,15 @@ class DeleteTwoFAStepScaffold extends ConsumerWidget {
     required this.headerDescription,
     required this.headerIcon,
     required this.child,
+    this.contentPadding,
     super.key,
   });
 
   final String headerTitle;
   final String headerDescription;
   final Widget headerIcon;
   final Widget child;
+  final double? contentPadding;
 
   @override
   Widget build(BuildContext context, WidgetRef ref) {
@@ -46,7 +48,7 @@ class DeleteTwoFAStepScaffold extends ConsumerWidget {
             description: headerDescription,
             icon: AuthHeaderIcon(icon: headerIcon),
           ),
-          SizedBox(height: 64.0.s),
+          SizedBox(height: contentPadding ?? 64.0.s),
           Expanded(child: child),
         ],
       ),