chore: add overflow rule for button label

ice-blockchain · Feb 13, 2024 · a6fedd4 · a6fedd4
1 parent b44ce38
commit a6fedd4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/lib/app/components/button/button.dart b/lib/app/components/button/button.dart
@@ -35,6 +35,7 @@ class Button extends StatelessWidget {
     required Widget icon,
     ButtonType type,
     ButtonStyle style,
+    Color? tintColor,
     double size,
   }) = _ButtonWithIcon;
 
@@ -82,6 +83,7 @@ class Button extends StatelessWidget {
       child: IconTheme(
         data: IconThemeData(color: _getIconTintColor(context, type)),
         child: DefaultTextStyle(
+          overflow: TextOverflow.ellipsis,
           style: context.theme.appTextThemes.body
               .copyWith(color: _getLabelColor(context, type)),
           child: Row(
@@ -90,13 +92,16 @@ class Button extends StatelessWidget {
             children: <Widget>[
               if (leadingIcon != null) leadingIcon!,
               if (label != null)
-                Padding(
-                  padding: EdgeInsets.only(
-                    left:
-                        leadingIcon == null ? 0 : 8.0.s, // 8 move to constants
-                    right: trailingIcon == null ? 0 : 8.0.s,
+                Flexible(
+                  child: Padding(
+                    padding: EdgeInsets.only(
+                      left: leadingIcon == null
+                          ? 0
+                          : 8.0.s, // 8 move to constants
+                      right: trailingIcon == null ? 0 : 8.0.s,
+                    ),
+                    child: label,
                   ),
-                  child: label,
                 ),
               if (trailingIcon != null) trailingIcon!,
             ],

diff --git a/lib/app/components/button/variants/button_icon.dart b/lib/app/components/button/variants/button_icon.dart
@@ -4,6 +4,7 @@ class _ButtonWithIcon extends Button {
   _ButtonWithIcon({
     super.key,
     super.type,
+    super.tintColor,
     required super.onPressed,
     required Widget icon,
     ButtonStyle style = const ButtonStyle(),

diff --git a/lib/app/components/button/widgetbook.dart b/lib/app/components/button/widgetbook.dart
@@ -123,6 +123,7 @@ Widget iconButtonUseCase(BuildContext context) {
         ),
         Button.icon(
           size: 40.0.s,
+          tintColor: context.theme.appColors.attentionRed,
           type: ButtonType.outlined,
           icon: ImageIcon(
             AssetImage(Assets.images.filter.path),