-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete/react/bookmark message #486
Merged
ice-damocles
merged 10 commits into
master
from
feature/origin/delete-react-bookmark-message
Jan 3, 2025
Merged
feat: delete/react/bookmark message #486
ice-damocles
merged 10 commits into
master
from
feature/origin/delete-react-bookmark-message
Jan 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice-damocles
force-pushed
the
feature/origin/delete-react-bookmark-message
branch
from
December 30, 2024 16:09
ff7bbf3
to
5026c68
Compare
ice-damocles
changed the title
Feature/origin/delete react bookmark message
feat: delete/react/bookmark message
Dec 30, 2024
ice-kreios
previously approved these changes
Dec 31, 2024
ice-tychon
reviewed
Dec 31, 2024
ice-tychon
reviewed
Dec 31, 2024
ice-tychon
reviewed
Dec 31, 2024
ice-tychon
reviewed
Dec 31, 2024
ice-tychon
reviewed
Dec 31, 2024
lib/app/features/chat/providers/conversation_message_actions_provider.c.dart
Outdated
Show resolved
Hide resolved
ice-tychon
reviewed
Dec 31, 2024
lib/app/features/chat/providers/conversation_message_actions_provider.c.dart
Show resolved
Hide resolved
ice-damocles
force-pushed
the
feature/origin/delete-react-bookmark-message
branch
from
December 31, 2024 09:05
0b3aef6
to
4bd8578
Compare
ice-kreios
previously approved these changes
Dec 31, 2024
ice-damocles
force-pushed
the
feature/origin/delete-react-bookmark-message
branch
from
December 31, 2024 10:04
4bd8578
to
d13c86d
Compare
lib/app/features/chat/providers/conversation_message_actions_provider.c.dart
Outdated
Show resolved
Hide resolved
There is an issue with Group/Channels, after this PR, there are two mocks left: addChannelConversation Can you please fix that in the scope of this PR. |
ice-damocles
force-pushed
the
feature/origin/delete-react-bookmark-message
branch
from
December 31, 2024 15:02
d13c86d
to
9dffb15
Compare
ice-endymion
previously approved these changes
Dec 31, 2024
ice-damocles
dismissed stale reviews from ice-endymion and ice-kreios
via
December 31, 2024 15:09
7fed0f1
ice-damocles
force-pushed
the
feature/origin/delete-react-bookmark-message
branch
from
January 3, 2025 08:07
7fed0f1
to
b81bf70
Compare
ice-kreios
approved these changes
Jan 3, 2025
ice-tychon
approved these changes
Jan 3, 2025
ice-ajax
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change