Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete/react/bookmark message #486

Merged
merged 10 commits into from
Jan 3, 2025

Conversation

ice-damocles
Copy link
Contributor

@ice-damocles ice-damocles commented Dec 30, 2024

Description

  • Providers to manage conversation actions (mark as sent, read, deleted, bookmark, add reaction)
  • Refactoring (seperated DB conversation service from DB file)
  • Delete conversation method

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation
  • Chore

@ice-damocles ice-damocles requested review from a team as code owners December 30, 2024 15:59
@ice-damocles ice-damocles force-pushed the feature/origin/delete-react-bookmark-message branch from ff7bbf3 to 5026c68 Compare December 30, 2024 16:09
@ice-damocles ice-damocles enabled auto-merge (squash) December 30, 2024 16:09
@ice-damocles ice-damocles changed the title Feature/origin/delete react bookmark message feat: delete/react/bookmark message Dec 30, 2024
ice-kreios
ice-kreios previously approved these changes Dec 31, 2024
ice-kreios
ice-kreios previously approved these changes Dec 31, 2024
@ice-damocles ice-damocles force-pushed the feature/origin/delete-react-bookmark-message branch from 4bd8578 to d13c86d Compare December 31, 2024 10:04
@ice-endymion
Copy link
Contributor

ice-endymion commented Dec 31, 2024

There is an issue with Group/Channels, after this PR, there are two mocks left:

addChannelConversation
addGroupConversation

Can you please fix that in the scope of this PR.

@ice-damocles ice-damocles force-pushed the feature/origin/delete-react-bookmark-message branch from d13c86d to 9dffb15 Compare December 31, 2024 15:02
ice-endymion
ice-endymion previously approved these changes Dec 31, 2024
@ice-damocles ice-damocles force-pushed the feature/origin/delete-react-bookmark-message branch from 7fed0f1 to b81bf70 Compare January 3, 2025 08:07
@ice-damocles ice-damocles merged commit 7b74e49 into master Jan 3, 2025
1 check passed
@ice-damocles ice-damocles deleted the feature/origin/delete-react-bookmark-message branch January 3, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants