initial version of cometbft consensus integration processing only assigned users/chains #24
Conversation
ice-cronus
changed the title
database/command/command.go
Outdated
| it := query.GetStoredEvents(ctx, &model.Subscription{Filters: model.Filters{ | ||
| model.Filter{IDs: eTag}, | ||
| }}) | ||
| for ev := range it { |
database/command/command.go
Outdated
| } | ||
| func mapTxToEvent(tx types.Tx) (*model.Event, error) { | ||
| var ev model.Event | ||
| if err := easyjson.Unmarshal(tx, &ev); err != nil { |
database/command/command_test.go
Outdated
| require.NoError(t, repostEvent.Sign(nostr.GeneratePrivateKey())) | ||
| require.NoError(t, c.broadcastUserEvents(context.TODO(), repostEvent)()) | ||
| }) | ||
| query.MustInit(context.TODO()) |
There was a problem hiding this comment.
Can we move that query.MustInit() into TestMain?
database/query/query.go
Outdated
| @@ -153,8 +179,8 @@ on conflict do update set | |||
| tags = excluded.tags, | |||
| d_tag = excluded.d_tag, | |||
| reference_id = excluded.reference_id, | |||
| hidden = 0 | |||
| ` | |||
| hidden = %[1]v | |||
There was a problem hiding this comment.
Keep that stmt as const and use excluded.hidden here.
server/ws/subscriptions_test.go
Outdated
| t.Run("query events", func(t *testing.T) { | ||
| events, err := relay.QuerySync(ctx, nostr.Filter{Kinds: []int{nostr.KindTextNote}}) | ||
| if err != nil { | ||
| log.Panic(err) |
There was a problem hiding this comment.
require.NoError(t, err)
server/ws/ws_test.go
Outdated
| @@ -80,6 +82,7 @@ func TestMain(m *testing.M) { | |||
| serverCancel() | |||
|
|
|||
| if code == 0 { | |||
| time.Sleep(10 * time.Second) | |||
database/command/command_test.go
Outdated
| ) | ||
|
|
||
| func newConsensus() *consensus { | ||
| return mustInit(context.Background()).(*consensus) |
There was a problem hiding this comment.
test context, with timeout
database/query/global.go
Outdated
| func AcceptEvents(ctx context.Context, events ...*model.Event) error { | ||
| return globalDB.Client.AcceptEvents(ctx, events...) | ||
| func AcceptEvents(ctx context.Context, consenusAccepted bool, events ...*model.Event) error { | ||
| return globalDB.Client.AcceptEvents(ctx, consenusAccepted, events...) |
There was a problem hiding this comment.
no, don't do that;
add a new func RollbackAcceptedEvents(ctx context.Context, events ...*model.Event) error { that u call to rollback
| return errors.Wrapf(err, "failed to command.AcceptEvent(%#v)", events) | ||
| } | ||
| if err := query.AcceptEvents(ctx, events...); err != nil { | ||
| command.RegisterConsensusEventListener(func(ctx context.Context, events ...*model.Event) error { |
There was a problem hiding this comment.
why do u have 2 EventListeners?
There was a problem hiding this comment.
second is when consensus accepted, we need it to accept events broadcasted by other nodes and currently it is used to mark as consensus accepted on current / initial node as well
database/command/global.go
Outdated
| for chainID, mxNode := range globalNodes { | ||
| mxnode := (mxNode.GetInstance().(*node.Node)) | ||
| broadcasters[chainID] = multiplex.NewChainInstance(chainID, local.New(mxnode)) | ||
| go func(chain string, n *node.Node) { |
There was a problem hiding this comment.
u no longer need that; its been fixed in https://tip.golang.org/doc/go1.22
|
|
||
| if w.Len() > 0 { | ||
| w.WriteString(" AND ") | ||
| if !w.IncludeHidden { |
There was a problem hiding this comment.
a better idea to try to generate a delete logic based on the events, so u can rollback the inserts, would be to have a mapping between a requestID and the resulted rows inserted
so that you can rollback by simply delete by pk directly; or insert by sql directly
U modify the normal flow to save the results (RETURNING *) of the sql in a sync.Map
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/ice-blockchain/subzero | |||
|
|
|||
| go 1.23.3 | |||
| go 1.23.2 | |||
ice-cronus
force-pushed
the
feature/cometbft_consensus
branch
from
b1348b1 to
835ba63
Compare
…igned users/chains
ice-cronus
force-pushed
the
feature/cometbft_consensus
branch
from
835ba63 to
60efbb3
Compare
No description provided.