expiration for storage events / files #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice-ares
reviewed
Dec 20, 2024
ice-cronus
force-pushed
the
bugfix/storage_expiration
branch
from
0d6e3cc to
a456150
Compare
ice-ares
previously approved these changes
Dec 20, 2024
ice-myles
previously approved these changes
Dec 20, 2024
database/query/query.go
Outdated
| tags as jtags; | ||
| `, params) | ||
| if err != nil { | ||
| err = errors.Wrap(db.handleError(err), "failed to exec insert event sql") |
server/http/storage_nip_96_test.go
Outdated
Comment on lines
232
to
239
| expiredTriggered := false | ||
| query.RegisterExpiredEventsProcessor(func(ctx context.Context, events ...*model.Event) error { | ||
| expiredTriggered = true | ||
| return storage.DeleteExpiredFiles(ctx, events...) | ||
| }) | ||
| log.Print("Wait for expiration trigger...") | ||
| time.Sleep(65 * time.Second) | ||
| require.True(t, expiredTriggered) |
There was a problem hiding this comment.
ch := make(chan struct{}, 1)
query.RegisterExpiredEventsProcessor(func(ctx context.Context, events ...*model.Event) error {
ch <- struct{}{}
return storage.DeleteExpiredFiles(ctx, events...)
})
log.Print("Wait for expiration trigger...")
select {
case <-ch:
case <- time.After(65 * time.Second):
t.Fatal("Expired events processor was not triggered")
}I would use smth like that. As a side note, 65 seconds ?
ice-dionysos
approved these changes
Dec 20, 2024
ice-cronus
force-pushed
the
bugfix/storage_expiration
branch
from
b0d1c54 to
3c4e721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.