Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle only postgres and network errors as unexpected. #28

Merged
merged 1 commit into from
Jan 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions connectors/storage/v2/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package storage

import (
"context"
"net"
"strings"
stdlibtime "time"

Expand Down Expand Up @@ -174,14 +175,10 @@ func IsErr(err, target error, column ...string) bool {
}

func IsUnexpected(err error) bool {
return !IsErr(err, ErrDuplicate) &&
!IsErr(err, ErrRelationNotFound) &&
!IsErr(err, ErrNotFound) &&
!IsErr(err, ErrCheckFailed) &&
!IsErr(err, ErrRelationInUse) &&
!IsErr(err, ErrSerializationFailure) &&
!IsErr(err, ErrTxAborted) &&
!IsErr(err, ErrExclusionViolation)
var pgConnErr *pgconn.PgError
var netOpErr *net.OpError

return errors.As(err, &pgConnErr) || errors.As(err, &netOpErr)
}

func parseDBError(err error) error { //nolint:funlen // .
Expand Down
Loading