fix: hash ack value before sending to verify membership for ics8 client

icon-project · Feb 7, 2024 · 537cfa2 · 537cfa2
1 parent ec773cf
commit 537cfa2
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/contracts/javascore/ibc/src/main/java/ibc/ics04/channel/IBCPacket.java b/contracts/javascore/ibc/src/main/java/ibc/ics04/channel/IBCPacket.java
@@ -377,6 +377,11 @@ private void verifyPacketAcknowledgement(
             byte[] path,
             byte[] acknowledgementCommitmentBytes) {
         ILightClient client = getClient(connection.getClientId());
+
+        if (IBCCommitment.getHashType(connection.getClientId()) == IBCHost.HashType.ICS08.type) {
+                acknowledgementCommitmentBytes = IBCCommitment.sha256(acknowledgementCommitmentBytes);
+        }
+
         client.verifyMembership(
                 connection.getClientId(),
                 height,