Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add IBC setup using DIVE CLI to readme #767

Merged
merged 5 commits into from
Oct 23, 2023
Merged

docs: add IBC setup using DIVE CLI to readme #767

merged 5 commits into from
Oct 23, 2023

Conversation

shreyasbhat0
Copy link
Collaborator

Description

Commit Message

docs: add IBC setup using DIVE CLI to readme

see the guidelines for commit messages.

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@shreyasbhat0 shreyasbhat0 added the documentation Improvements or additions to documentation label Oct 18, 2023
@MuhammedIrfan MuhammedIrfan requested a review from FezBox October 19, 2023 05:54
@ibrizsabin ibrizsabin added the enhancement New feature or request label Oct 19, 2023
ibrizsabin
ibrizsabin previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks shreyas , nice work.

izyak
izyak reviewed Oct 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
AntonAndell
AntonAndell approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@AntonAndell AntonAndell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Was easy enough to run 👍

@AntonAndell AntonAndell merged commit 335a316 into icon-project:main Oct 23, 2023
3 checks passed
@shreyasbhat0 shreyasbhat0 deleted the docs/update-readme-for-setting-up-IBC-using-dive-cli branch October 24, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izyak izyak izyak left review comments

@AntonAndell AntonAndell AntonAndell approved these changes

@ibrizsabin ibrizsabin ibrizsabin left review comments

@FezBox FezBox Awaiting requested review from FezBox

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreyasbhat0 @AntonAndell @izyak @ibrizsabin