Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ICS20 App on IBC #793
feat: add ICS20 App on IBC #793
Changes from 6 commits
45e890d
4b606e3
c790b28
bd9181f
c074ebe
750fa1e
c7789bd
288e857
a24d0ab
4674725
6b0cfa0
bec141a
31e14c1
2a442e2
1491efc
099b387
f6e7615
cc56743
a7ac65d
1e40a29
2668cc4
e35e841
10955ff
45ef0dd
0ccbb1b
89e57ce
1b7622a
33f9515
ee328eb
78aa099
427b14b
75a89f5
df44436
ad67542
447f3ce
aa659bc
6c96e08
611c8c8
4dc2a46
c0a685f
aa8ac65
f8a1ec3
4b52e25
67d3212
fe28512
9a1e784
7703072
f6f40e5
505f952
ce504d9
c287d3c
17c84bb
0594a7b
60a0dff
c633bb3
e40fbb2
a9f18e0
a629251
301681c
0dc813c
cbd799b
7da48fd
476d79b
8e7ee1c
5c97bc7
7237b0b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldnot length of denom be always greater than denomPrefix? .i think we would need to compare denom prefix with packet sourcePort and sourceChannel to determine if sender is source or sink then burn token if sender is source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can decode packet from calldata ... and lets rename it to packetBytes as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to refund on packet timeout as well.