Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests #815

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: tests #815

merged 1 commit into from
Jan 3, 2024

Conversation

izyak
Copy link
Collaborator

@izyak izyak commented Jan 3, 2024 •
edited
Loading

Description

Commit Message

hotfix: neutron client

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@izyak izyak changed the title hotfix: update trusting period for neutron client fix: update trusting period for neutron client Jan 3, 2024
@izyak izyak added the bug Something isn't working label Jan 3, 2024
@izyak izyak changed the title fix: update trusting period for neutron client fix: tests Jan 3, 2024
AntonAndell
AntonAndell approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine

@izyak izyak merged commit af511b1 into release/v1.1.1 Jan 3, 2024
11 of 18 checks passed
@izyak izyak deleted the hotfix/neutron-client-trusting-period branch January 3, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonAndell AntonAndell AntonAndell approved these changes

@redlarva redlarva Awaiting requested review from redlarva

@ibrizsabin ibrizsabin Awaiting requested review from ibrizsabin ibrizsabin is a code owner

@nightowl121 nightowl121 Awaiting requested review from nightowl121 nightowl121 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izyak @AntonAndell