Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Edit tendermint proto files to comply with non wasm clients #819

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Jan 5, 2024

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@AntonAndell AntonAndell linked an issue Jan 5, 2024 that may be closed by this pull request
@AntonAndell AntonAndell force-pushed the 805-create-ics-08-compatible-tendermint-lightclient-in-java branch from b8de168 to 1d8f528 Compare January 5, 2024 12:38
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9a90959) 70.10% compared to head (4bce6c8) 70.10%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #819      +/-   ##
============================================
- Coverage     70.10%   70.10%   -0.01%     
  Complexity      409      409              
============================================
  Files           155      155              
  Lines         13947    13946       -1     
  Branches        293      293              
============================================
- Hits           9778     9777       -1     
  Misses         4016     4016              
  Partials        153      153              
Flag Coverage Δ
java 81.11% <84.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../ibc/src/main/java/ibc/ics02/client/IBCClient.java 100.00% <ø> (ø)
.../main/java/ibc/ics03/connection/IBCConnection.java 97.01% <ø> (ø)
...in/java/ibc/ics04/channel/IBCChannelHandshake.java 85.98% <ø> (ø)
...ibc/src/main/java/ibc/ics04/channel/IBCPacket.java 87.35% <ø> (ø)
...bc/src/main/java/ibc/ics05/port/ModuleManager.java 100.00% <ø> (ø)
...c/src/main/java/ibc/ics23/commitment/Compress.java 94.23% <ø> (ø)
.../ibc/src/main/java/ibc/ics23/commitment/Ics23.java 74.62% <ø> (ø)
.../ibc/src/main/java/ibc/ics23/commitment/Proof.java 69.00% <ø> (ø)
...c/main/java/ibc/ics23/commitment/types/Merkle.java 34.93% <ø> (ø)
...ore/ibc/src/main/java/ibc/ics24/host/IBCStore.java 83.72% <ø> (ø)
... and 9 more

@AntonAndell AntonAndell force-pushed the 805-create-ics-08-compatible-tendermint-lightclient-in-java branch from 1d8f528 to 4bce6c8 Compare January 5, 2024 13:01
AntonAndell and others added 2 commits January 17, 2024 12:45
Add revision number but for now do not add support for resseting chain height
* feat: hash depending on client type

* feat: add IBC prefix for ics-08 clients and bugfixes (#826)

* feat: Add revision number to light client heights

Add revision number but for now do not add support for resseting chain height

* revert to using two clients

* feat: add IBC prefix for ics-08 clients and bugfixes

* fix: hash ack value before sending to verify membership for ics8 client

---------

Co-authored-by: izyak <[email protected]>

---------

Co-authored-by: izyak <[email protected]>
ibrizsabin
ibrizsabin previously approved these changes Feb 29, 2024
Copy link
Collaborator

@nightowl121 nightowl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@AntonAndell AntonAndell changed the base branch from main to feature/wasm-lightclient-ibc-changes March 11, 2024 08:52
@AntonAndell AntonAndell merged commit feebe68 into feature/wasm-lightclient-ibc-changes Mar 11, 2024
10 checks passed
@AntonAndell AntonAndell deleted the 805-create-ics-08-compatible-tendermint-lightclient-in-java branch March 11, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ICS-08 compatible Tendermint lightclient in Java
4 participants