-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Edit tendermint proto files to comply with non wasm clients #819
Merged
AntonAndell
merged 4 commits into
feature/wasm-lightclient-ibc-changes
from
805-create-ics-08-compatible-tendermint-lightclient-in-java
Mar 11, 2024
Merged
feat: Edit tendermint proto files to comply with non wasm clients #819
AntonAndell
merged 4 commits into
feature/wasm-lightclient-ibc-changes
from
805-create-ics-08-compatible-tendermint-lightclient-in-java
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonAndell
requested review from
redlarva,
ibrizsabin and
nightowl121
as code owners
January 5, 2024 12:25
AntonAndell
force-pushed
the
805-create-ics-08-compatible-tendermint-lightclient-in-java
branch
from
January 5, 2024 12:38
b8de168
to
1d8f528
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
============================================
- Coverage 70.10% 70.10% -0.01%
Complexity 409 409
============================================
Files 155 155
Lines 13947 13946 -1
Branches 293 293
============================================
- Hits 9778 9777 -1
Misses 4016 4016
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AntonAndell
force-pushed
the
805-create-ics-08-compatible-tendermint-lightclient-in-java
branch
from
January 5, 2024 13:01
1d8f528
to
4bce6c8
Compare
Add revision number but for now do not add support for resseting chain height
* feat: hash depending on client type * feat: add IBC prefix for ics-08 clients and bugfixes (#826) * feat: Add revision number to light client heights Add revision number but for now do not add support for resseting chain height * revert to using two clients * feat: add IBC prefix for ics-08 clients and bugfixes * fix: hash ack value before sending to verify membership for ics8 client --------- Co-authored-by: izyak <[email protected]> --------- Co-authored-by: izyak <[email protected]>
ibrizsabin
previously approved these changes
Feb 29, 2024
ibrizsabin
approved these changes
Mar 4, 2024
nightowl121
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
AntonAndell
changed the base branch from
main
to
feature/wasm-lightclient-ibc-changes
March 11, 2024 08:52
AntonAndell
merged commit Mar 11, 2024
feebe68
into
feature/wasm-lightclient-ibc-changes
10 checks passed
AntonAndell
deleted the
805-create-ics-08-compatible-tendermint-lightclient-in-java
branch
March 11, 2024 08:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist