Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wasm lightclient ibc changes javascore #859

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Apr 26, 2024

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

AntonAndell and others added 9 commits January 5, 2024 14:01
Add revision number but for now do not add support for resseting chain height
* feat: hash depending on client type

* feat: add IBC prefix for ics-08 clients and bugfixes (#826)

* feat: Add revision number to light client heights

Add revision number but for now do not add support for resseting chain height

* revert to using two clients

* feat: add IBC prefix for ics-08 clients and bugfixes

* fix: hash ack value before sending to verify membership for ics8 client

---------

Co-authored-by: izyak <[email protected]>

---------

Co-authored-by: izyak <[email protected]>
…e-tendermint-lightclient-in-java

feat: Edit tendermint proto files to comply with non wasm clients
* fix: acknowledgement compare issue fixed

* fix: address comparision in tokenFallback
* feat: Add revision number to light client heights

Add revision number but for now do not add support for resseting chain height

* wip

* revert to using two clients

* feat: add IBC prefix for ics-08 clients and bugfixes

* fix: Require tendermint clientstate trustlevel to be >= 1/3

* feat: Apply code improvments suggested during audit (#831)
@ibrizsabin ibrizsabin changed the title feature: wasm lightclient ibc changes feature: wasm lightclient ibc changes javascore Apr 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 73.05936% with 59 lines in your changes missing coverage. Please review.

Project coverage is 76.41%. Comparing base (c277c32) to head (e76b4b4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #859      +/-   ##
============================================
+ Coverage     76.28%   76.41%   +0.12%     
+ Complexity      418      405      -13     
============================================
  Files           155      152       -3     
  Lines         14447    14033     -414     
  Branches        292      280      -12     
============================================
- Hits          11021    10723     -298     
+ Misses         3279     3157     -122     
- Partials        147      153       +6     
Flag Coverage Δ
java 81.59% <73.05%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/cosmwasm-vm/cw-ibc-core/src/contract.rs 36.49% <ø> (-1.62%) ⬇️
...osmwasm-vm/cw-ibc-core/src/ics02_client/handler.rs 97.89% <ø> (-0.02%) ⬇️
...-vm/cw-ibc-core/src/ics03_connection/connection.rs 93.84% <ø> (+2.17%) ⬆️
...asm-vm/cw-ibc-core/src/ics03_connection/handler.rs 100.00% <ø> (ø)
...smwasm-vm/cw-ibc-core/src/ics04_channel/handler.rs 100.00% <ø> (ø)
...c-core/src/ics04_channel/packet/acknowledgement.rs 97.39% <ø> (-0.13%) ⬇️
...bc-core/src/ics04_channel/packet/receive_packet.rs 97.63% <ø> (-0.07%) ⬇️
...w-ibc-core/src/ics04_channel/packet/send_packet.rs 100.00% <ø> (ø)
...-core/src/ics04_channel/packet/timeout_on_close.rs 100.00% <ø> (ø)
...s/cosmwasm-vm/cw-icon-light-client/src/contract.rs 66.09% <ø> (ø)
... and 24 more

... and 6 files with indirect coverage changes

ibrizsabin and others added 4 commits May 15, 2024 11:02
* fix: audit issues

* fix: cleanup
* feat: add wasm client project

* fix: add wasm proto

* fix: import ics08wasm

* fix: import wasm-08

* fix: generalize context

* fix: build deps

* fix: fix deps issue

* fix: split query handler

* fix: wrap result in response

* feat: add verify header

* feat: add genesis export

* fix: impl client status

* fix: fix unit test

* fix: add debug logs

* fix: cleanup

* chore: pass build

* fix: proto changes

* fix: split traits

* chore: pass build

* fix: remove inner

* fix: query handler

* fix: add tests

* fix: add update test

* fix: downgrade

* fix: downgrade cosmwasm

* fix: update test utils

* fix: point to downgraded xcall

* fix: lower multi test

* fix: lock on 1.6

* fix: revert downgrade

* fix: try disable features

* fix: upgrade cw-storage-plus

* fix: lock to 1.4

* fix: move cw-multi test

* chore: pass build

* fix: fix branch

* fix: add height

* fix: cleanup

* chore: pass build

* fix: remove toolchain.toml

* fix: fix verify membership

* fix: ack hashing

* doc: add build note

* chore: pass build

* fix: do sha256

* fix: check misbehaviour

* chore: pass build

* fix:resolve comments

* chore: pass build

* fix: remove unnecessary hash

* chore: pass build

* fix: rename client id

* fix: Fix reverse sign on timestamp check for request timeout

* chore: update test coverage for ibc client (#846)

* chore: update test coverage for ics03-connection (#848)

* chore: update test coverage for ibc client

* chore: improve test coverage for ibc connection

* chore: add test coverage for cosmwasm ibc core (#850)

* docs: Add explanation on how a connection can be manually verified (#838)

doc: Add explanation on how a connection can be manually verified

* fix: add reference to CI workflow to fix error (#839)

Co-authored-by: ForwardSlashBack <[email protected]>

* chore: add unit test coverage for icon light client (#851)

* ci: add injectived, and neutornd binary (#858)

* ci: add injectived, and neutornd binary

* ci: update archwayd to v6.0.0

* ci: update archwayd to v6.0.0

* chore: add test coverage for xcall-ibc-connection (#853)

* fix: fix test

* fix: resolve test issues

* fix: cargo fmt

---------

Co-authored-by: AntonAndell <[email protected]>
Co-authored-by: undefined <[email protected]>
Co-authored-by: ForwardSlashBack <[email protected]>
Co-authored-by: ForwardSlashBack <[email protected]>
Co-authored-by: DeepakBomjan <[email protected]>
* docs: add ics-20 deviation

* fix: remove transfer from

* updates on ICS20 specs

* chore: typo

* docs: separate function for sendICX and save tokenAddress

---------

Co-authored-by: izyak <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 15, 2024
@ibrizsabin ibrizsabin changed the title feature: wasm lightclient ibc changes javascore feat: wasm lightclient ibc changes javascore May 15, 2024
@ibrizsabin ibrizsabin marked this pull request as ready for review May 15, 2024 05:42
@ibrizsabin ibrizsabin marked this pull request as draft May 15, 2024 05:49
… … (#832)

* add: added framework for remote chan tests and TC for token transfer to-and-from ibc-centauri

* fix: added test wallets and configs for e2e

* fix: added test cases to cover stake transfer from centauri to icon

* fix: increased timeouts and add sha256sum of latest light client wasm

* added test keys for relayer for deevnet

* feat: added testcase for icon-archway and back via centauri hopchain

* chore: refactorings and adjust timeouts

* chore: added sample config

* chore: added sample config file to run in devnet with configured connection

* chore: removed extra logging

* chore: added codes in makefile to run hopchain tests

* chore: made receivers configurable and updated docs

* chore: updated docs for old xcall tests and new ones

* fix: fixed case of wallet of chain

* fix: fixed case of gh actions issue

* fix: remove old test

* fix: fixed PR comments

---------

Co-authored-by: ibrizsabin <[email protected]>
Co-authored-by: ibrizsabin <[email protected]>
@github-actions github-actions bot added the test Testing update for Unit test, Integration test and E2E testing label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:major documentation Improvements or additions to documentation scripts test Testing update for Unit test, Integration test and E2E testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants