Feat: implement bitcoin relayer #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wallet (#2) * feat: add transmission and bitcoin module --------- Co-authored-by: k0r1 <[email protected]>
Add Bitcoin taproot multisig wallet library
…wallet (#2) * feat: add transmission and bitcoin module --------- Co-authored-by: k0r1 <[email protected]>
fix: build multisig tx with rollback case
feat: handle callback
fix: del cache relaymessage after success
fix: remove unused
fix: slave select default input from master
feat: mainnet test
chore: clean code
bcsainju
reviewed
Nov 19, 2024
relayer/chains/evm/event_parse.go
Outdated
| @@ -12,7 +13,9 @@ func (p *Provider) getRelayMessageFromLog(log types.Log) (*providerTypes.Message | |||
| return nil, fmt.Errorf("topic length mismatch") | |||
| } | |||
| topic := log.Topics[0] | |||
|
|
|||
| if len(topic) != 0 { | |||
There was a problem hiding this comment.
Wouldn't this logic break the existing implementation as we are doing the bitcoin relay for all the topic messages ?
There was a problem hiding this comment.
This is just redundant code, we have reviewed but left them out.
I removed them!
bcsainju
reviewed
Nov 19, 2024
relayer/transmission/transmission.go
Outdated
|
|
||
| body, err := io.ReadAll(resp.Body) | ||
| if err != nil { | ||
| log.Fatalf("Error reading response: %v", err) |
There was a problem hiding this comment.
Consider replacing FatalF with other severity as it means printf followed by os.exit leading the application to exit for every error. The relayer uses zap logger
There was a problem hiding this comment.
I removed these redundant codes too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Features:
Docs:
Including testing results and how to use bitcoin relayer
Mainnet contracts:
Checklist:
(https://github.com/icon-project/community/blob/main/guidelines/technical/software-development-guidelines.md#commit-messages)