Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added loading message to Grade Distribution #337

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Jul 28, 2023

Description

  1. Instead of returning null while loading, we now return a loading message return <>Loading Distribution..</>;

Screenshots

Before:

After (search):
Screenshot 2023-07-29 at 2 43 23 AM

After (course):
Screenshot 2023-07-29 at 2 44 22 AM

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment
  • Delete branch

(optional)

  • Write tests
  • Write documentation

Closes #336

Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Deployed staging instance to https://staging-337.peterportal.org

@KevinWu098 KevinWu098 merged commit 5bbec33 into master Aug 29, 2023
2 checks passed
@js0mmer js0mmer deleted the gradeDistLoadingMsg branch August 29, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grade Distribution has no loading message
2 participants