Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pull_request_template.md #342

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Update pull_request_template.md #342

merged 1 commit into from
Aug 12, 2023

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Aug 1, 2023 •
edited by js0mmer
Loading

Add Closes # to the PR template

Description

Screenshots

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment
  • Delete branch

(optional)

  • Write tests
  • Write documentation

@KevinWu098
Update pull_request_template.md
6edb00d 
Add `Closes #` to the PR template
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Deployed staging instance to https://staging-342.peterportal.org

js0mmer
js0mmer approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@js0mmer js0mmer merged commit 5052310 into master Aug 12, 2023
@js0mmer js0mmer deleted the KevinWu098-patch-1 branch August 12, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js0mmer js0mmer js0mmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinWu098 @js0mmer